Re: [PATCH v8] perf: add qcom l2 cache perf events driver

2017-02-03 Thread Mark Rutland
Hi, On Wed, Feb 01, 2017 at 02:57:55PM -0500, Leeder, Neil wrote: > >>+ conflict_event = > >>+ cluster->events[cluster->group_to_counter[group]]; > >>+ if (conflict_event != event) { > > > >If it's possible for conflict_event == event, it sounds like this is >

Re: [PATCH v8] perf: add qcom l2 cache perf events driver

2017-02-01 Thread Leeder, Neil
Mark, Thanks for all the comments and code samples. I will update the patch and repost. On 1/30/2017 10:19 AM, Mark Rutland wrote: On Mon, Jan 16, 2017 at 01:52:47PM -0500, Neil Leeder wrote: This is fine as is, but just for my understanding, I take it that the locking is only strictly requir

Re: [PATCH v8] perf: add qcom l2 cache perf events driver

2017-01-30 Thread Mark Rutland
Hi Neil, Apologies for the delay in getting to this. This is largely looking good now. I have a couple of concerns with the hotplug logic, but I think we can solve those without too much pain. More on that below. On Mon, Jan 16, 2017 at 01:52:47PM -0500, Neil Leeder wrote: > +#define L2PMRESR_

Re: [PATCH v8] perf: add qcom l2 cache perf events driver

2017-01-29 Thread Leeder, Neil
Has anyone had a chance to look at this yet - I'd appreciate any comments. Thanks, Neil On 1/16/2017 1:52 PM, Neil Leeder wrote: Adds perf events support for L2 cache PMU. The L2 cache PMU driver is named 'l2cache_0' and can be used with perf events to profile L2 events such as cache hits and