Re: [PATCH v7 3/5] fw_cfg: do DMA read operation

2017-11-21 Thread Michael S. Tsirkin
On Tue, Nov 21, 2017 at 06:17:46AM -0500, Marc-André Lureau wrote: > > > @@ -57,6 +72,12 @@ struct fw_cfg_file { > > > char name[FW_CFG_MAX_FILE_PATH]; > > > }; > > > > > > +struct fw_cfg_dma { > > > + u32 control; > > > + u32 length; > > > + u64 address; > > > +} __packed; > > > + > > > /* f

Re: [PATCH v7 3/5] fw_cfg: do DMA read operation

2017-11-21 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Nov 20, 2017 at 10:55:17AM +0100, Marc-André Lureau wrote: > > Modify fw_cfg_read_blob() to use DMA if the device supports it. > > Return errors, because the operation may fail. > > > > The DMA operation is expected to run synchronously with today qemu, >

Re: [PATCH v7 3/5] fw_cfg: do DMA read operation

2017-11-20 Thread Michael S. Tsirkin
On Mon, Nov 20, 2017 at 10:55:17AM +0100, Marc-André Lureau wrote: > Modify fw_cfg_read_blob() to use DMA if the device supports it. > Return errors, because the operation may fail. > > The DMA operation is expected to run synchronously with today qemu, > but the specification states that it may b