Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-03-19 Thread Andrey Smirnov
On Mon, Mar 18, 2013 at 1:11 PM, Mauro Carvalho Chehab wrote: > Em Tue, 26 Feb 2013 22:06:45 -0800 > Andrey Smirnov escreveu: > >> This patch adds all the functions used for exchanging commands with >> the chip. > > Please run checkpatch.pl over those patches. There are a number of compliants > o

Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-03-18 Thread Mauro Carvalho Chehab
Em Tue, 26 Feb 2013 22:06:45 -0800 Andrey Smirnov escreveu: > This patch adds all the functions used for exchanging commands with > the chip. Please run checkpatch.pl over those patches. There are a number of compliants on those patches: WARNING: externs should be avoided in .c files #210: FILE