Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

Hi Namhyung, On Tue, 2018-12-04 at 16:25 +0900, Namhyung Kim wrote: > On Mon, Dec 03, 2018 at 04:22:02PM -0600, Tom Zanussi wrote: > > Hi Namhyung, > > > > On Fri, 2018-11-23 at 11:50 +0900, Namhyung Kim wrote: > > > Hi Tom, > > > > > > On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

On Mon, Dec 03, 2018 at 04:22:02PM -0600, Tom Zanussi wrote: > Hi Namhyung, > > On Fri, 2018-11-23 at 11:50 +0900, Namhyung Kim wrote: > > Hi Tom, > > > > On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > > > From: Tom Zanussi > > > > > [snip] > > > > > enum handler_id { > > >

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

Hi Namhyung, On Fri, 2018-11-23 at 11:50 +0900, Namhyung Kim wrote: > Hi Tom, > > On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > > From: Tom Zanussi > > [snip] > > enum handler_id { > > HANDLER_ONMATCH = 1, > > HANDLER_ONMAX, > > @@ -349,14 +358,18 @@ struct action_d

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

Hi Namhyung, On Fri, 2018-11-23 at 16:01 +0900, Namhyung Kim wrote: > On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > > From: Tom Zanussi > > > > [snip] > > - > > - update_max_vars(hist_data, elt, rbe, rec); > > + if (update_track_val(hist_data, elt, data, var_ref_vals)) >

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > From: Tom Zanussi > > The action refactor code allowed actions and handlers to be separated, > but the existing onmax handler and save action code is still not > flexible enough to handle arbitrary coupling. This change generalizes >

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

Hi Tom, On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > From: Tom Zanussi > > The action refactor code allowed actions and handlers to be separated, > but the existing onmax handler and save action code is still not > flexible enough to handle arbitrary coupling. This change gene