Re: [PATCH v7 0/3] media: v4l2-subdev: Verify arguments in v4l2_subdev_call()

2019-06-29 Thread Hans Verkuil
On 6/29/19 5:28 AM, Niklas Söderlund wrote: > Hi, > > This patch breaks rcar-vin. I'm sorry I did not find out before it was > merged as a8fa55078a7784a9 ("media: v4l2-subdev: Verify arguments in > v4l2_subdev_call()"). > > The problem is that rcar-vin calls enum_mbus_code in its bound callback

Re: [PATCH v7 0/3] media: v4l2-subdev: Verify arguments in v4l2_subdev_call()

2019-06-28 Thread Niklas Söderlund
Hi, This patch breaks rcar-vin. I'm sorry I did not find out before it was merged as a8fa55078a7784a9 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()"). The problem is that rcar-vin calls enum_mbus_code in its bound callback. At this point call_enum_mbus_code() is invoked which t

Re: [PATCH v7 0/3] media: v4l2-subdev: Verify arguments in v4l2_subdev_call()

2019-06-17 Thread Hans Verkuil
Sakari, Are you OK with this series? Please Ack if that's the case, so that I can merge it. Regards, Hans On 5/20/19 11:27 PM, Janusz Krzysztofik wrote: > Correctness of format type (try or active) and pad ID parameters passed > to subdevice operation callbacks is now verified only for

Re: [PATCH v7 0/3] media: v4l2-subdev: Verify arguments in v4l2_subdev_call()

2019-05-29 Thread Sakari Ailus
Hi Janusz, On Mon, May 20, 2019 at 11:27:44PM +0200, Janusz Krzysztofik wrote: > Correctness of format type (try or active) and pad ID parameters passed > to subdevice operation callbacks is now verified only for IOCTL calls. > However, those callbacks are also used by drivers, e.g., V4L2 host > i