Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-15 Thread Jiang Liu
Hi Will, Thanks for review. On 12/13/2013 11:41 PM, Will Deacon wrote: > Hi Jiang Liu, > > Thanks for the updated patches! I still have some small comments, but I > don't think they will cause you much work. See inline. > > On Tue, Dec 10, 2013 at 04:03:52PM +, Jiang Liu wrote: >> Opt

Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-15 Thread Jiang Liu
On 12/13/2013 11:52 PM, Steven Rostedt wrote: > On Fri, 13 Dec 2013 10:50:23 -0500 > Steven Rostedt wrote: > >> On Fri, 13 Dec 2013 15:41:04 + >> Will Deacon wrote: >> +#include +#include +#include +#include + +#ifdef HAVE_JUMP_LABEL >>> >>> Slightly worryin

Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-13 Thread Will Deacon
On Fri, Dec 13, 2013 at 03:50:23PM +, Steven Rostedt wrote: > On Fri, 13 Dec 2013 15:41:04 + > Will Deacon wrote: > > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#ifdef HAVE_JUMP_LABEL > > > > Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL

Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-13 Thread Steven Rostedt
On Fri, 13 Dec 2013 10:50:23 -0500 Steven Rostedt wrote: > On Fri, 13 Dec 2013 15:41:04 + > Will Deacon wrote: > > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#ifdef HAVE_JUMP_LABEL > > > > Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, rig

Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-13 Thread Steven Rostedt
On Fri, 13 Dec 2013 15:41:04 + Will Deacon wrote: > > +#include > > +#include > > +#include > > +#include > > + > > +#ifdef HAVE_JUMP_LABEL > > Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did > you manage to test this code? In we have: #if defined(CC_HAVE_AS

Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

2013-12-13 Thread Will Deacon
Hi Jiang Liu, Thanks for the updated patches! I still have some small comments, but I don't think they will cause you much work. See inline. On Tue, Dec 10, 2013 at 04:03:52PM +, Jiang Liu wrote: > Optimize jump label implementation for ARM64 by dynamically patching > kernel text. > > Signed