Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-14 Thread AKASHI Takahiro
On 03/14/2014 07:07 PM, Will Deacon wrote: On Fri, Mar 14, 2014 at 04:45:13AM +, AKASHI Takahiro wrote: On 03/14/2014 02:08 AM, Will Deacon wrote: On Thu, Mar 13, 2014 at 10:13:47AM +, AKASHI Takahiro wrote: This patch implements arm64 specific part to support function tracers, such as

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-14 Thread Will Deacon
On Fri, Mar 14, 2014 at 04:45:13AM +, AKASHI Takahiro wrote: > On 03/14/2014 02:08 AM, Will Deacon wrote: > > On Thu, Mar 13, 2014 at 10:13:47AM +, AKASHI Takahiro wrote: > >> This patch implements arm64 specific part to support function tracers, > >> such as function (CONFIG_FUNCTION_TRACE

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-13 Thread AKASHI Takahiro
On 03/14/2014 02:08 AM, Will Deacon wrote: On Thu, Mar 13, 2014 at 10:13:47AM +, AKASHI Takahiro wrote: This patch implements arm64 specific part to support function tracers, such as function (CONFIG_FUNCTION_TRACER), function_graph (CONFIG_FUNCTION_GRAPH_TRACER) and function profiler (CONFI

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-13 Thread Steven Rostedt
On Thu, 2014-03-13 at 18:37 +, Will Deacon wrote: > > > No, return_hooker is consistent with all the other archs. Hey, it's a > > rugby position! Note, which I was when I played. ;-) > > Hehe, in which case your children will be able to execute that line of > ftrace! > My kids already know

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-13 Thread Will Deacon
On Thu, Mar 13, 2014 at 06:27:39PM +, Steven Rostedt wrote: > On Thu, 2014-03-13 at 17:08 +, Will Deacon wrote: > > > > + /* > > > +* Note: > > > +* No protection against faulting at *parent, which may be seen > > > +* on other archs. It's unlikely on AArch64.

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-13 Thread Steven Rostedt
On Thu, 2014-03-13 at 17:08 +, Will Deacon wrote: > > + /* > > +* Note: > > +* No protection against faulting at *parent, which may be seen > > +* on other archs. It's unlikely on AArch64. > > +*/ > > + old = *parent; > > + *parent = return_hoo

Re: [PATCH v6 4/7] arm64: Add ftrace support

2014-03-13 Thread Will Deacon
On Thu, Mar 13, 2014 at 10:13:47AM +, AKASHI Takahiro wrote: > This patch implements arm64 specific part to support function tracers, > such as function (CONFIG_FUNCTION_TRACER), function_graph > (CONFIG_FUNCTION_GRAPH_TRACER) and function profiler > (CONFIG_FUNCTION_PROFILER). > > With 'funct