Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-26 Thread Ravi Bangoria
Hi Kim, I've tested your patch on x86 and powerpc and it looks fine to me. Can you please put your signed-off-by. Please add Act-by: Ravi Bangoria as well. Regards, -Ravi On Wednesday 24 August 2016 02:06 AM, Kim Phillips wrote: > On Tue, 23 Aug 2016 11:17:16 +0900 > Namhyung Kim wrote: > >>

Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-25 Thread Namhyung Kim
Hi, On Tue, Aug 23, 2016 at 03:36:17PM -0500, Kim Phillips wrote: > On Tue, 23 Aug 2016 11:17:16 +0900 > Namhyung Kim wrote: > > > On Tue, Aug 23, 2016 at 8:01 AM, Kim Phillips wrote: > > > On Fri, 19 Aug 2016 18:29:33 +0530 > > > Ravi Bangoria wrote: > > > > > >> Changes in v6: > > >> - Ins

Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-23 Thread Kim Phillips
On Tue, 23 Aug 2016 11:17:16 +0900 Namhyung Kim wrote: > On Tue, Aug 23, 2016 at 8:01 AM, Kim Phillips wrote: > > On Fri, 19 Aug 2016 18:29:33 +0530 > > Ravi Bangoria wrote: > > > >> Changes in v6: > >> - Instead of adding only those instructions defined in #ifdef __arm__, > >> add all in

Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-22 Thread Namhyung Kim
Hello, On Tue, Aug 23, 2016 at 8:01 AM, Kim Phillips wrote: > On Fri, 19 Aug 2016 18:29:33 +0530 > Ravi Bangoria wrote: > >> Changes in v6: >> - Instead of adding only those instructions defined in #ifdef __arm__, >> add all instructions from default table to arm table. > .. >> +static str

Re: [PATCH v6 2/7] perf annotate: Add cross arch annotate support

2016-08-22 Thread Kim Phillips
On Fri, 19 Aug 2016 18:29:33 +0530 Ravi Bangoria wrote: > Changes in v6: > - Instead of adding only those instructions defined in #ifdef __arm__, > add all instructions from default table to arm table. .. > +static struct ins instructions_arm[] = { > { .name = "add", .ops = &mov_op