Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Lee Jones
On Tue, 28 Jul 2020, Uwe Kleine-König wrote: > On Tue, Jul 28, 2020 at 10:21:22AM +0200, Michael Walle wrote: > > Am 2020-07-28 09:43, schrieb Uwe Kleine-König: > > > On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > > > > +static int sl28cpld_pwm_probe(struct platform_device *pdev)

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Uwe Kleine-König
Hallo, On Tue, Jul 28, 2020 at 10:21:22AM +0200, Michael Walle wrote: > Am 2020-07-28 09:43, schrieb Uwe Kleine-König: > > On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > > > +static int sl28cpld_pwm_probe(struct platform_device *pdev) > > > +{ > > > + struct sl28cpld_pwm *priv; >

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Michael Walle
Hi, Am 2020-07-28 09:43, schrieb Uwe Kleine-König: Hello, just a few minor issues left: thanks for the review. On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c new file mode 100644 index ..956fa

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-28 Thread Uwe Kleine-König
Hello, just a few minor issues left: On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c > new file mode 100644 > index ..956fa09f3aba > --- /dev/null > +++ b/drivers/pwm/pwm-sl28cpld.c > @@ -0,0 +1,223

Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller

2020-07-27 Thread Thierry Reding
On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > Add support for the PWM controller of the sl28cpld board management > controller. This is part of a multi-function device driver. > > The controller has one PWM channel and can just generate four distinct > frequencies. > > Signed-o