Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-11-06 Thread Javier Martinez Canillas
Hello Wolfram, On 11/05/2017 10:53 PM, Wolfram Sang wrote: > On Sun, Oct 01, 2017 at 12:49:48PM +0200, Javier Martinez Canillas wrote: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C de

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-11-05 Thread Wolfram Sang
On Sun, Oct 01, 2017 at 12:49:48PM +0200, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID a

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-10-18 Thread Javier Martinez Canillas
On Tue, Oct 17, 2017 at 11:40 PM, Wolfram Sang wrote: > Hi, > >> + { >> + .compatible = "atmel,spd", >> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8, >> + AT24_FLAG_READONLY | AT24_FLAG_IRUGO) >> + }, > > checkpatch reported this one as u

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-10-17 Thread Geert Uytterhoeven
Hi Wolfram, On Tue, Oct 17, 2017 at 11:40 PM, Wolfram Sang wrote: >> + { >> + .compatible = "atmel,spd", >> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8, >> + AT24_FLAG_READONLY | AT24_FLAG_IRUGO) >> + }, > > checkpatch reported this one

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-10-17 Thread Wolfram Sang
On Tue, Oct 17, 2017 at 04:43:14PM -0500, Rob Herring wrote: > On Tue, Oct 17, 2017 at 4:40 PM, Wolfram Sang wrote: > > Hi, > > > >> + { > >> + .compatible = "atmel,spd", > >> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8, > >> + AT24_FLAG_REA

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-10-17 Thread Rob Herring
On Tue, Oct 17, 2017 at 4:40 PM, Wolfram Sang wrote: > Hi, > >> + { >> + .compatible = "atmel,spd", >> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8, >> + AT24_FLAG_READONLY | AT24_FLAG_IRUGO) >> + }, > > checkpatch reported this one as un

Re: [PATCH v6] eeprom: at24: Add OF device ID table

2017-10-17 Thread Wolfram Sang
Hi, > + { > + .compatible = "atmel,spd", > + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8, > + AT24_FLAG_READONLY | AT24_FLAG_IRUGO) > + }, checkpatch reported this one as un-documented. And come to think of it, since this is solely for EE