Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-25 Thread Andy Shevchenko
On Wed, Nov 25, 2015 at 11:12 AM, Dave Penkler wrote: > On Sun, Nov 22, 2015 at 12:36:53PM +0200, Andy Shevchenko wrote: > OK so now I have the same as in v4 again: > > if (rv < 0) { > dev_err(dev, "simple usb_control_msg failed %d\n", rv); > goto exit; >

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-25 Thread Dave Penkler
On Sun, Nov 22, 2015 at 12:36:53PM +0200, Andy Shevchenko wrote: > On Sun, Nov 22, 2015 at 10:51 AM, Dave Penkler wrote: > > On Wed, Nov 18, 2015 at 11:41:30AM +0200, Andy Shevchenko wrote: > >> On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: > > > >> > + if (rv < 0) { > >> > +

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-22 Thread Andy Shevchenko
On Sun, Nov 22, 2015 at 10:51 AM, Dave Penkler wrote: > On Wed, Nov 18, 2015 at 11:41:30AM +0200, Andy Shevchenko wrote: >> On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: >> > + if (rv < 0) { >> > + dev_err(dev, "simple usb_control_msg failed %d\n", rv); >> > +

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-22 Thread Dave Penkler
On Wed, Nov 18, 2015 at 11:41:30AM +0200, Andy Shevchenko wrote: > On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: > > These ioctls provide support for the USBTMC-USB488 control requests > > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT > > Couple of comments below. > > > diff --git a/dri

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-18 Thread Andy Shevchenko
On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: > These ioctls provide support for the USBTMC-USB488 control requests > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Couple of comments below. > diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c > index 2358991..d416a5f 1