Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Thomas Gleixner
On Tue, 20 Sep 2016, Alexandre Torgue wrote: > so if you agree I will resend only patches concerning stm32 exti driver > [1],[2],[3],[4] Ok. > Thanks for your time. Welcome, tglx

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Alexandre Torgue
Thomas, On 09/20/2016 04:02 PM, Thomas Gleixner wrote: On Tue, 20 Sep 2016, Alexandre Torgue wrote: On 09/20/2016 02:44 PM, Thomas Gleixner wrote: Free will be called when a interrupt in the child domain is torn down, i.e. when irq_domain_free_irqs() is called. And it will be called for both d

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Thomas Gleixner
On Tue, 20 Sep 2016, Alexandre Torgue wrote: > On 09/20/2016 02:44 PM, Thomas Gleixner wrote: > > Free will be called when a interrupt in the child domain is torn down, > > i.e. when irq_domain_free_irqs() is called. And it will be called for both > > domains like the alloc callback is invoked on b

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Alexandre Torgue
Thomas, On 09/20/2016 02:44 PM, Thomas Gleixner wrote: On Tue, 20 Sep 2016, Alexandre Torgue wrote: Thomas, On 09/20/2016 11:51 AM, Thomas Gleixner wrote: On Tue, 20 Sep 2016, Alexandre Torgue wrote: On 09/14/2016 03:34 PM, Thomas Gleixner wrote: Well, you just used some function in some c

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Thomas Gleixner
On Tue, 20 Sep 2016, Alexandre Torgue wrote: > Thomas, > > On 09/20/2016 11:51 AM, Thomas Gleixner wrote: > > On Tue, 20 Sep 2016, Alexandre Torgue wrote: > > > > On 09/14/2016 03:34 PM, Thomas Gleixner wrote: > > > > > Well, you just used some function in some context which is not > > > > > rele

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Alexandre Torgue
Thomas, On 09/20/2016 11:51 AM, Thomas Gleixner wrote: On Tue, 20 Sep 2016, Alexandre Torgue wrote: On 09/14/2016 03:34 PM, Thomas Gleixner wrote: Well, you just used some function in some context which is not relevant to the normal operation. So adding that mask() is just paranoia for no valu

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Thomas Gleixner
On Tue, 20 Sep 2016, Alexandre Torgue wrote: > > On 09/14/2016 03:34 PM, Thomas Gleixner wrote: > > > Well, you just used some function in some context which is not > > > relevant to > > > the normal operation. So adding that mask() is just paranoia for no > > > value. > > > A gentle reminder ping

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-20 Thread Alexandre Torgue
Hi Thomas, On 09/14/2016 03:44 PM, Alexandre Torgue wrote: On 09/14/2016 03:34 PM, Thomas Gleixner wrote: On Wed, 14 Sep 2016, Alexandre Torgue wrote: On 09/14/2016 11:19 AM, Thomas Gleixner wrote: Now what really bugs me is that you do that at all. An interrupt which is freed must be mask

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-14 Thread Alexandre Torgue
On 09/14/2016 03:34 PM, Thomas Gleixner wrote: On Wed, 14 Sep 2016, Alexandre Torgue wrote: On 09/14/2016 11:19 AM, Thomas Gleixner wrote: Now what really bugs me is that you do that at all. An interrupt which is freed must be masked already. Why is it unmasked in the first place? Honestly

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-14 Thread Thomas Gleixner
On Wed, 14 Sep 2016, Alexandre Torgue wrote: > On 09/14/2016 11:19 AM, Thomas Gleixner wrote: > > > > Now what really bugs me is that you do that at all. An interrupt which is > > freed must be masked already. Why is it unmasked in the first place? > > Honestly I don't know. When "devm_free_irq"

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-14 Thread Alexandre Torgue
Hi Thomas, On 09/14/2016 11:19 AM, Thomas Gleixner wrote: On Tue, 13 Sep 2016, Alexandre Torgue wrote: On 09/13/2016 05:21 PM, Thomas Gleixner wrote: On Fri, 9 Sep 2016, Alexandre TORGUE wrote: +static void stm32_exti_free(struct irq_domain *d, unsigned int virq, + u

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-14 Thread Thomas Gleixner
On Tue, 13 Sep 2016, Alexandre Torgue wrote: > On 09/13/2016 05:21 PM, Thomas Gleixner wrote: > > On Fri, 9 Sep 2016, Alexandre TORGUE wrote: > > > +static void stm32_exti_free(struct irq_domain *d, unsigned int virq, > > > + unsigned int nr_irqs) > > > +{ > > > + struct irq_dat

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-13 Thread Alexandre Torgue
Hi Thomas, On 09/13/2016 05:21 PM, Thomas Gleixner wrote: On Fri, 9 Sep 2016, Alexandre TORGUE wrote: +static void stm32_exti_free(struct irq_domain *d, unsigned int virq, + unsigned int nr_irqs) +{ + struct irq_data *data = irq_get_irq_data(virq); + + irq_

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-13 Thread Thomas Gleixner
On Fri, 9 Sep 2016, Alexandre TORGUE wrote: > +static void stm32_exti_free(struct irq_domain *d, unsigned int virq, > + unsigned int nr_irqs) > +{ > + struct irq_data *data = irq_get_irq_data(virq); > + > + irq_gc_mask_clr_bit(data->parent_data); I have a hard time

Re: [PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-13 Thread Marc Zyngier
On 09/09/16 15:41, Alexandre TORGUE wrote: > The STM32 external interrupt controller consists of edge detectors that > generate interrupts requests or wake-up events. > > Each line can be independently configured as interrupt or wake-up source, > and triggers either on rising, falling or both edge