Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-18 Thread David.Wu
Hi Wolfram, 在 2016/4/16 1:58, Wolfram Sang 写道: The default frequency rate of function clock is 50M Hz, it can match F/S mode, but HS mode not. If use default rate 50M to get 1.7M scl-frequency rate , we could not get accurately 1.7M frequecy rate. The input-clk-rate is more higher, we get more a

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-15 Thread Wolfram Sang
> The default frequency rate of function clock is 50M Hz, it can match > F/S mode, but HS mode not. If use default rate 50M to get 1.7M > scl-frequency rate , we could not get accurately 1.7M frequecy rate. > The input-clk-rate is more higher, we get more accurately > scl-frequency rate, as 200M i

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-15 Thread Heiko Stübner
Hi David, Am Donnerstag, 17. März 2016, 00:57:18 schrieb David Wu: > From: David Wu > > - new method to caculate i2c timings for rk3399: > There was an timing issue about "repeated start" time at the I2C > controller of version0, controller appears to drop SDA at .875x (7/8) > programmed c

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-15 Thread David.Wu
Hi Heiko, 在 2016/4/15 15:31, Heiko Stübner 写道: David, Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang: + - input-clk-rate : frequency rate of function clock used(in Hz). If omitted, + the default clock rate is used. It is just used at rk3399 soc. Why is this needed? Why don'

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-15 Thread David.Wu
Hi Wolfram, 在 2016/4/15 2:48, Wolfram Sang 写道: + - input-clk-rate : frequency rate of function clock used(in Hz). If omitted, + the default clock rate is used. It is just used at rk3399 soc. Why is this needed? Why don't we simply use the default or calculate the best value somehow? The d

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-15 Thread Heiko Stübner
David, Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang: > > + - input-clk-rate : frequency rate of function clock used(in Hz). If > > omitted, + the default clock rate is used. It is just used at rk3399 soc. > > Why is this needed? Why don't we simply use the default or calculate th

Re: [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc

2016-04-14 Thread Wolfram Sang
> + - input-clk-rate : frequency rate of function clock used(in Hz). If omitted, > + the default clock rate is used. It is just used at rk3399 soc. Why is this needed? Why don't we simply use the default or calculate the best value somehow? > + * @t_calc: Caculated rk3x private timings that