Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-04 Thread Masami Hiramatsu
On Wed, 4 Nov 2020 09:47:22 -0500 Steven Rostedt wrote: > On Wed, 4 Nov 2020 11:08:52 +0900 > Masami Hiramatsu wrote: > > > kretprobe_hash_lock() and kretprobe_table_lock() will be called from > > outside of the kprobe pre_handler context. So, please keep in_nmi() > > in those functions. > > fo

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-04 Thread Steven Rostedt
On Wed, 4 Nov 2020 11:08:52 +0900 Masami Hiramatsu wrote: > kretprobe_hash_lock() and kretprobe_table_lock() will be called from > outside of the kprobe pre_handler context. So, please keep in_nmi() > in those functions. > for the pre_handler_kretprobe(), this looks good to me. > Final version,

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-03 Thread Masami Hiramatsu
On Tue, 3 Nov 2020 11:09:13 -0500 Steven Rostedt wrote: > On Tue, 3 Nov 2020 14:39:38 +0900 > Masami Hiramatsu wrote: > > > Ah, OK. This looks good to me. > > > > BTW, in_nmi() in pre_handler_kretprobe() always be true because > > now int3 is treated as an NMI. So you can always pass 1 there.

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-03 Thread Steven Rostedt
On Tue, 3 Nov 2020 14:39:38 +0900 Masami Hiramatsu wrote: > Ah, OK. This looks good to me. > > BTW, in_nmi() in pre_handler_kretprobe() always be true because > now int3 is treated as an NMI. So you can always pass 1 there. What about the below patch then? > > Acked-by: Masami Hiramatsu Tha

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-02 Thread Masami Hiramatsu
On Mon, 2 Nov 2020 09:27:26 -0500 Steven Rostedt wrote: > > [ Peter Z, please take a look a this ] > > On Mon, 2 Nov 2020 16:02:34 +0900 > Masami Hiramatsu wrote: > > > >From 509b27efef8c7dbf56cab2e812916d6cd778c745 Mon Sep 17 00:00:00 2001 > > From: Masami Hiramatsu > > Date: Mon, 2 Nov 2

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-02 Thread Steven Rostedt
[ Peter Z, please take a look a this ] On Mon, 2 Nov 2020 16:02:34 +0900 Masami Hiramatsu wrote: > >From 509b27efef8c7dbf56cab2e812916d6cd778c745 Mon Sep 17 00:00:00 2001 > From: Masami Hiramatsu > Date: Mon, 2 Nov 2020 15:37:28 +0900 > Subject: [PATCH] kprobes: Disable lockdep for kprobe b

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-01 Thread Masami Hiramatsu
On Mon, 2 Nov 2020 14:53:34 +0900 Masami Hiramatsu wrote: > On Mon, 2 Nov 2020 14:11:38 +0900 > Masami Hiramatsu wrote: > > > On Fri, 30 Oct 2020 21:38:31 -0400 > > Steven Rostedt wrote: > > > > > On Sat, 29 Aug 2020 22:02:36 +0900 > > > Masami Hiramatsu wrote: > > > > > > > Since the commi

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-01 Thread Masami Hiramatsu
On Mon, 2 Nov 2020 14:11:38 +0900 Masami Hiramatsu wrote: > On Fri, 30 Oct 2020 21:38:31 -0400 > Steven Rostedt wrote: > > > On Sat, 29 Aug 2020 22:02:36 +0900 > > Masami Hiramatsu wrote: > > > > > Since the commit 9b38cc704e84 ("kretprobe: Prevent triggering > > > kretprobe from within kprob

Re: [PATCH v5 14/21] kprobes: Remove NMI context check

2020-11-01 Thread Masami Hiramatsu
On Fri, 30 Oct 2020 21:38:31 -0400 Steven Rostedt wrote: > On Sat, 29 Aug 2020 22:02:36 +0900 > Masami Hiramatsu wrote: > > > Since the commit 9b38cc704e84 ("kretprobe: Prevent triggering > > kretprobe from within kprobe_flush_task") sets a dummy current > > kprobe in the trampoline handler by