Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-21 Thread Pierre Morel
On 19/03/2019 18:07, Pierre Morel wrote: On 19/03/2019 15:54, Halil Pasic wrote: On Tue, 19 Mar 2019 11:01:44 +0100 Pierre Morel wrote: On 15/03/2019 18:28, Halil Pasic wrote: ...snip... We should also do it right for TAPQ with t bit set. I remember Christian already warned about this

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-19 Thread Pierre Morel
On 19/03/2019 15:54, Halil Pasic wrote: On Tue, 19 Mar 2019 11:01:44 +0100 Pierre Morel wrote: On 15/03/2019 18:28, Halil Pasic wrote: [..] Things get complicated when one considers that ECA.28 is an effective control. I don't think so, ECA_28 is not really a problem. We do not propagat

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-19 Thread Halil Pasic
On Tue, 19 Mar 2019 11:01:44 +0100 Pierre Morel wrote: > On 15/03/2019 18:28, Halil Pasic wrote: [..] > > > > Things get complicated when one considers that ECA.28 is an effective > > control. > > I don't think so, ECA_28 is not really a problem. > We do not propagate ECA_AIV in VSIE and ECA_

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-19 Thread Pierre Morel
On 15/03/2019 18:28, Halil Pasic wrote: On Fri, 15 Mar 2019 14:26:34 +0100 Pierre Morel wrote: On 15/03/2019 11:20, Cornelia Huck wrote: On Wed, 13 Mar 2019 17:04:58 +0100 Pierre Morel wrote: +/* + * handle_pqap: Handling pqap interception + * @vcpu: the vcpu having issue the pqap instruct

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-19 Thread Pierre Morel
On 15/03/2019 15:10, Pierre Morel wrote: On 15/03/2019 14:26, Pierre Morel wrote: On 15/03/2019 11:20, Cornelia Huck wrote: On Wed, 13 Mar 2019 17:04:58 +0100 Pierre Morel wrote: +/* + * handle_pqap: Handling pqap interception + * @vcpu: the vcpu having issue the pqap instruction + * + * We

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Halil Pasic
On Fri, 15 Mar 2019 15:10:25 +0100 Pierre Morel wrote: > Sorry, wrong conclusion, handling this in userland will bring us much > too far if we want to answer correctly for the case the hook is not > there but QEMU accepted the facility for AQIC. > > The alternative is easier, we just continue

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Halil Pasic
On Fri, 15 Mar 2019 14:26:34 +0100 Pierre Morel wrote: > On 15/03/2019 11:20, Cornelia Huck wrote: > > On Wed, 13 Mar 2019 17:04:58 +0100 > > Pierre Morel wrote: > > > >> +/* > >> + * handle_pqap: Handling pqap interception > >> + * @vcpu: the vcpu having issue the pqap instruction > >> + * > >

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Pierre Morel
On 15/03/2019 14:26, Pierre Morel wrote: On 15/03/2019 11:20, Cornelia Huck wrote: On Wed, 13 Mar 2019 17:04:58 +0100 Pierre Morel wrote: +/* + * handle_pqap: Handling pqap interception + * @vcpu: the vcpu having issue the pqap instruction + * + * We now support PQAP/AQIC instructions and we

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Pierre Morel
On 15/03/2019 14:41, Cornelia Huck wrote: On Fri, 15 Mar 2019 14:26:34 +0100 Pierre Morel wrote: Conclusion: we must handle this in userland, it will have the benefit to keep old behavior when there is no callback. OLD QEMU will not see change as they will not set aqic facility NEW QEMU will

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Cornelia Huck
On Fri, 15 Mar 2019 14:26:34 +0100 Pierre Morel wrote: > Conclusion: we must handle this in userland, it will have the benefit > to keep old behavior when there is no callback. > OLD QEMU will not see change as they will not set aqic facility > NEW QEMU will handle this correctly. > > In this

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Pierre Morel
On 15/03/2019 11:20, Cornelia Huck wrote: On Wed, 13 Mar 2019 17:04:58 +0100 Pierre Morel wrote: +/* + * handle_pqap: Handling pqap interception + * @vcpu: the vcpu having issue the pqap instruction + * + * We now support PQAP/AQIC instructions and we need to correctly + * answer the guest eve

Re: [PATCH v5 1/7] s390: ap: kvm: add PQAP interception for AQIC

2019-03-15 Thread Cornelia Huck
On Wed, 13 Mar 2019 17:04:58 +0100 Pierre Morel wrote: > +/* > + * handle_pqap: Handling pqap interception > + * @vcpu: the vcpu having issue the pqap instruction > + * > + * We now support PQAP/AQIC instructions and we need to correctly > + * answer the guest even if no dedicated driver's hook i