Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

2012-09-04 Thread Andi Shyti
On Tue, Sep 04, 2012 at 07:46:02PM +0800, Dong Aisheng wrote: > On Tue, Sep 04, 2012 at 07:35:45PM +0800, Andi Shyti wrote: > > Hi Dong, > > > > On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote: > > > +static int __devinit syscon_probe(struct platform_device *pdev) > > > +{ > > > + str

Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

2012-09-04 Thread Sergei Shtylyov
Hello. On 04-09-2012 15:35, Andi Shyti wrote: +static int __devinit syscon_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; Do we really need this variable? Anyway you are using it only once in the dev_info. But Dong definitely could use it more than once,

Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

2012-09-04 Thread Dong Aisheng
On Tue, Sep 04, 2012 at 07:35:45PM +0800, Andi Shyti wrote: > Hi Dong, > > On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote: > > +static int __devinit syscon_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > Do we really need this variable? Anyway

Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

2012-09-04 Thread Andi Shyti
Hi Dong, On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote: > +static int __devinit syscon_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; Do we really need this variable? Anyway you are using it only once in the dev_info. > + struct device_node *