Re: [PATCH v5] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-05-08 Thread Masayoshi Mizuma
Hi Rik, On Wed, 30 Apr 2014 16:42:55 -0400 Rik van Riel wrote: > On Wed, 30 Apr 2014 13:13:53 -0700 > Andrew Morton wrote: > >> This was a consequence of 64->32 truncation and it can't happen any >> more, can it? > > Andrew, this is cleaner indeed :) > > Masayoshi-san, does the bug still happ

Re: [PATCH v5] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-05-02 Thread Michal Hocko
On Wed 30-04-14 16:42:55, Rik van Riel wrote: > On Wed, 30 Apr 2014 13:13:53 -0700 > Andrew Morton wrote: > > > This was a consequence of 64->32 truncation and it can't happen any > > more, can it? > > Andrew, this is cleaner indeed :) > > Masayoshi-san, does the bug still happen with this vers

Re: [PATCH v5] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Andrew Morton
On Wed, 30 Apr 2014 16:42:55 -0400 Rik van Riel wrote: > On Wed, 30 Apr 2014 13:13:53 -0700 > Andrew Morton wrote: > > > This was a consequence of 64->32 truncation and it can't happen any > > more, can it? > > Andrew, this is cleaner indeed :) > > Masayoshi-san, does the bug still happen wit

Re: [PATCH v5] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Rik van Riel
On 04/30/2014 05:00 PM, Andrew Morton wrote: On Wed, 30 Apr 2014 16:42:55 -0400 Rik van Riel wrote: On Wed, 30 Apr 2014 13:13:53 -0700 Andrew Morton wrote: This was a consequence of 64->32 truncation and it can't happen any more, can it? Andrew, this is cleaner indeed :) I'm starting to

Re: [PATCH v5] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Andrew Morton
On Wed, 30 Apr 2014 16:42:55 -0400 Rik van Riel wrote: > On Wed, 30 Apr 2014 13:13:53 -0700 > Andrew Morton wrote: > > > This was a consequence of 64->32 truncation and it can't happen any > > more, can it? > > Andrew, this is cleaner indeed :) I'm starting to get worried about 32-bit wraparo