Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-19 Thread Viresh Kumar
On 20 June 2013 04:19, Rafael J. Wysocki wrote: > Well, sentences that don't start from upper-case letters don't look like > separate sentences s/sequences/sentences for your initial mail. I misunderstood it as, you want to name cpu{0|1|2} as CPU{1|2|3}.. Obviously sentences must start with cap

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-19 Thread Rafael J. Wysocki
On Wednesday, June 19, 2013 11:26:13 AM Xiaoguang Chen wrote: > 2013/6/19 Viresh Kumar : > > On 19 June 2013 08:43, Viresh Kumar wrote: > >> On 19 June 2013 06:50, Xiaoguang Chen wrote: > >>> 2013/6/19 Rafael J. Wysocki : > >> > > 2) Current governor is userspace, now cpu0 hotplugs in cpu3, i

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-19 Thread Rafael J. Wysocki
On Wednesday, June 19, 2013 08:30:11 AM Viresh Kumar wrote: > On 19 June 2013 06:50, Xiaoguang Chen wrote: > > 2013/6/19 Rafael J. Wysocki : > >> On Thursday, June 13, 2013 05:01:58 PM Xiaoguang Chen wrote: > >>> cpufreq governor stop and start should be kept in sequence. > >>> If not, there will

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Xiaoguang Chen
2013/6/19 Viresh Kumar : > On 19 June 2013 08:43, Viresh Kumar wrote: >> On 19 June 2013 06:50, Xiaoguang Chen wrote: >>> 2013/6/19 Rafael J. Wysocki : >> > 2) Current governor is userspace, now cpu0 hotplugs in cpu3, it will Can you please tell me what the above is supposed to mean

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Viresh Kumar
On 19 June 2013 08:43, Viresh Kumar wrote: > On 19 June 2013 06:50, Xiaoguang Chen wrote: >> 2013/6/19 Rafael J. Wysocki : > 2) Current governor is userspace, now cpu0 hotplugs in cpu3, it will >>> >>> Can you please tell me what the above is supposed to mean? Is it supposed >>> to >>> mea

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Viresh Kumar
On 19 June 2013 06:50, Xiaoguang Chen wrote: > 2013/6/19 Rafael J. Wysocki : >>> 2) Current governor is userspace, now cpu0 hotplugs in cpu3, it will >> >> Can you please tell me what the above is supposed to mean? Is it supposed to >> mean "the online of cpu3 is being run on cpu0" or something

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Viresh Kumar
On 19 June 2013 06:50, Xiaoguang Chen wrote: > 2013/6/19 Rafael J. Wysocki : >> On Thursday, June 13, 2013 05:01:58 PM Xiaoguang Chen wrote: >>> cpufreq governor stop and start should be kept in sequence. >>> If not, there will be unexpected behavior, for example: >>> >>> we have 4 cpus and policy

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Xiaoguang Chen
2013/6/19 Rafael J. Wysocki : > On Thursday, June 13, 2013 05:01:58 PM Xiaoguang Chen wrote: >> cpufreq governor stop and start should be kept in sequence. >> If not, there will be unexpected behavior, for example: >> >> we have 4 cpus and policy->cpu=cpu0, cpu1/2/3 are linked to cpu0. > > Please s

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-18 Thread Rafael J. Wysocki
On Thursday, June 13, 2013 05:01:58 PM Xiaoguang Chen wrote: > cpufreq governor stop and start should be kept in sequence. > If not, there will be unexpected behavior, for example: > > we have 4 cpus and policy->cpu=cpu0, cpu1/2/3 are linked to cpu0. Please spell cpus as "CPUs". And please start

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-13 Thread Xiaoguang Chen
2013/6/13 Viresh Kumar : > On 13 June 2013 14:31, Xiaoguang Chen wrote: >> cpufreq governor stop and start should be kept in sequence. >> If not, there will be unexpected behavior, for example: >> >> we have 4 cpus and policy->cpu=cpu0, cpu1/2/3 are linked to cpu0. >> the normal sequence is as bel

Re: [PATCH v5] cpufreq: fix governor start/stop race condition

2013-06-13 Thread Viresh Kumar
On 13 June 2013 14:31, Xiaoguang Chen wrote: > cpufreq governor stop and start should be kept in sequence. > If not, there will be unexpected behavior, for example: > > we have 4 cpus and policy->cpu=cpu0, cpu1/2/3 are linked to cpu0. > the normal sequence is as below: > > 1) Current governor is u