Re: [PATCH v5] checkpatch: add support to check 'Fixes:' tag format

2020-05-03 Thread Markus Elfring
>>> + "Please use git commit description style >>> '$prefix <$sha1_length_min+ chars of sha1> (\"<$title>\")' - ie: >>> '${init_char}" . substr($prefix, 1) . >>> + " $id (\"$description\")'\n" . >>> $diagnostics . $herecurr); >> >>

Re: [PATCH v5] checkpatch: add support to check 'Fixes:' tag format

2020-05-03 Thread Wang YanQing
On Sun, May 03, 2020 at 03:51:39PM +0200, Markus Elfring wrote: > > > … > > + $diagnostics .= "The title is too > > abbreviated, at least half of orignial commit title is necessary.\n"; > > Will the word “original” be more appropriate here? > (Why did you not i

Re: [PATCH v5] checkpatch: add support to check 'Fixes:' tag format

2020-05-03 Thread Markus Elfring
> “... Can the character “Horizontal ellipsis” (U+2026) be occasionally nicer instead of three separate dots? > The check supports below formats: I would prefer the explicit wording for the support of (Unicode) ellipses also in the shown commit titles. Will the document “submitting-patches.rst”