RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-19 Thread Appana Durga Kedareswara Rao
.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org; robh...@kernel.org; > grant.lik...@linaro.org; Michal Simek; w...@grandegger.com; > fengguang...@intel.com > Subject: Re: [PATCH v5] can: xilinx CAN controller support. > > On 03/11/2014 01:48 PM, Marc Kleine-Budde wrote

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-13 Thread Fengguang Wu
Hi Michal, On Tue, Mar 11, 2014 at 10:38:14AM +0100, Michal Simek wrote: > On 03/11/2014 05:45 AM, Fengguang Wu wrote: > >>> You probably want something like > >>> > >>> config CAN_XILINX > >>> tristate "Xilinx CAN" > >>> depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > >>> depends on

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-12 Thread Sören Brinkmann
On Wed, 2014-03-12 at 11:18AM +0100, Michal Simek wrote: > Hi guys, > > > On 03/11/2014 03:31 PM, Marc Kleine-Budde wrote: > > On 03/11/2014 03:08 PM, Appana Durga Kedareswara Rao wrote: > > > >> + struct napi_struct napi; > >> + u32 (*read_reg)(const struct xcan_priv *priv, enum xca

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-12 Thread Michal Simek
Hi guys, On 03/11/2014 03:31 PM, Marc Kleine-Budde wrote: > On 03/11/2014 03:08 PM, Appana Durga Kedareswara Rao wrote: > >> + struct napi_struct napi; >> + u32 (*read_reg)(const struct xcan_priv *priv, enum xcan_reg reg); >> + void (*write_reg)(const struct xcan_priv *priv, en

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-12 Thread Michal Simek
On 03/11/2014 01:48 PM, Marc Kleine-Budde wrote: > On 03/11/2014 01:34 PM, Appana Durga Kedareswara Rao wrote: > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 9e7d95d..b180239 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -125

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-11 Thread Marc Kleine-Budde
On 03/11/2014 03:08 PM, Appana Durga Kedareswara Rao wrote: > + struct napi_struct napi; > + u32 (*read_reg)(const struct xcan_priv *priv, enum xcan_reg reg); > + void (*write_reg)(const struct xcan_priv *priv, enum xcan_reg reg, > + u32 val); > + stru

RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-11 Thread Appana Durga Kedareswara Rao
el@vger.kernel.org; > devicet...@vger.kernel.org; robh...@kernel.org; grant.lik...@linaro.org; > Michal Simek; w...@grandegger.com; fengguang...@intel.com > Subject: Re: [PATCH v5] can: xilinx CAN controller support. > > On 03/11/2014 01:34 PM, Appana Durga Kedareswara Rao wrote: >

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-11 Thread Marc Kleine-Budde
On 03/11/2014 01:34 PM, Appana Durga Kedareswara Rao wrote: >>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index >>> 9e7d95d..b180239 100644 >>> --- a/drivers/net/can/Kconfig >>> +++ b/drivers/net/can/Kconfig >>> @@ -125,6 +125,13 @@ config CAN_GRCAN >>> endian syntheses

RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-11 Thread Appana Durga Kedareswara Rao
..@vger.kernel.org; > netdev; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org; Appana Durga > Kedareswara Rao > Subject: Re: [PATCH v5] can: xilinx CAN controller support. > > On 03/10/2014 04:15 PM, Rob Herring wrote: > > O

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-11 Thread Michal Simek
On 03/11/2014 05:45 AM, Fengguang Wu wrote: >>> You probably want something like >>> >>> config CAN_XILINX >>> tristate "Xilinx CAN" >>> depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >>> depends on COMMON_CLK && HAS_MMIO # whatever you need for other >>> architectures >> >> F

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Fengguang Wu
> > You probably want something like > > > > config CAN_XILINX > > tristate "Xilinx CAN" > > depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > > depends on COMMON_CLK && HAS_MMIO # whatever you need for other > > architectures > > Fengguang: Are you use COMPILE_TEST in zero d

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Michal Simek
On 03/10/2014 04:15 PM, Arnd Bergmann wrote: > On Monday 10 March 2014 16:10:31 Marc Kleine-Budde wrote: > +config CAN_XILINXCAN > + tristate "Xilinx CAN" > + depends on ARCH_ZYNQ || MICROBLAZE Is Zynq multiarch already? >>> >>> let me just answer this. Zynq is device with

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Michal Simek
On 03/10/2014 04:15 PM, Rob Herring wrote: > On Tue, Mar 4, 2014 at 7:20 AM, Kedareswara rao Appana > wrote: >> This patch adds xilinx CAN controller support. >> This driver supports both ZYNQ CANPS and Soft IP >> AXI CAN controller. >> >> Signed-off-by: Kedareswara rao Appana >> --- >> This patc

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Arnd Bergmann
On Monday 10 March 2014 16:10:31 Marc Kleine-Budde wrote: > >>> +config CAN_XILINXCAN > >>> + tristate "Xilinx CAN" > >>> + depends on ARCH_ZYNQ || MICROBLAZE > >> > >> Is Zynq multiarch already? > > > > let me just answer this. Zynq is device with hardcoded dual arm cortex-a9 + > > some IPs

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Rob Herring
On Tue, Mar 4, 2014 at 7:20 AM, Kedareswara rao Appana wrote: > This patch adds xilinx CAN controller support. > This driver supports both ZYNQ CANPS and Soft IP > AXI CAN controller. > > Signed-off-by: Kedareswara rao Appana > --- > This patch is rebased on the 3.14 rc5 kernel. > Changes for v5:

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Marc Kleine-Budde
On 03/10/2014 04:04 PM, Michal Simek wrote: > Hi Marc, > > On 03/10/2014 03:57 PM, Marc Kleine-Budde wrote: >> On 03/04/2014 02:20 PM, Kedareswara rao Appana wrote: >>> This patch adds xilinx CAN controller support. >>> This driver supports both ZYNQ CANPS and Soft IP >>> AXI CAN controller. >>> >

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Michal Simek
Hi Marc, On 03/10/2014 03:57 PM, Marc Kleine-Budde wrote: > On 03/04/2014 02:20 PM, Kedareswara rao Appana wrote: >> This patch adds xilinx CAN controller support. >> This driver supports both ZYNQ CANPS and Soft IP >> AXI CAN controller. >> >> Signed-off-by: Kedareswara rao Appana >> --- >> This

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Marc Kleine-Budde
On 03/04/2014 02:20 PM, Kedareswara rao Appana wrote: > This patch adds xilinx CAN controller support. > This driver supports both ZYNQ CANPS and Soft IP > AXI CAN controller. > > Signed-off-by: Kedareswara rao Appana > --- > This patch is rebased on the 3.14 rc5 kernel. > Changes for v5: > - Upd

RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-10 Thread Appana Durga Kedareswara Rao
Hi Marc, Can you please comment on this patch? I got comments from the Soren and Oliver if you provide your comments also will send next version of patch BTW: I seen the below patch form the Oliver can: Unify MTU settings for CAN interfaces Do i need to make this change also in to this driver? R

RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-04 Thread Appana Durga Kedareswara Rao
.@linaro.org; robh...@kernel.org; linux- > c...@vger.kernel.org; net...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; Appana Durga Kedareswara Rao > Subject: Re: [PATCH v5] can: xilinx CAN controller support. > > > >

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-04 Thread Oliver Hartkopp
On 05.03.2014 00:51, Sören Brinkmann wrote: > Hi Kedar, > > On Tue, 2014-03-04 at 06:50PM +0530, Kedareswara rao Appana wrote: >> This patch adds xilinx CAN controller support. >> This driver supports both ZYNQ CANPS and Soft IP >> AXI CAN controller. >> > [...] >> diff --git a/Documentation/dev

RE: [PATCH v5] can: xilinx CAN controller support.

2014-03-04 Thread Appana Durga Kedareswara Rao
@kernel.org; linux-...@vger.kernel.org; > net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org; Appana Durga > Kedareswara Rao > Subject: Re: [PATCH v5] can: xilinx CAN controller support. > > Hi Kedar, > > On Tue

Re: [PATCH v5] can: xilinx CAN controller support.

2014-03-04 Thread Sören Brinkmann
Hi Kedar, On Tue, 2014-03-04 at 06:50PM +0530, Kedareswara rao Appana wrote: > This patch adds xilinx CAN controller support. > This driver supports both ZYNQ CANPS and Soft IP > AXI CAN controller. > [...] > diff --git a/Documentation/devicetree/bindings/net/can/xilinx_can.txt > b/Documentation