Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, On 06/03/2015 01:27 PM, Lee Jones wrote: > On Wed, 03 Jun 2015, Javier Martinez Canillas wrote: [snip] >> >> >> >> - err = mfd_add_devices(dev, 0, cros_devs, >> >> - ARRAY_SIZE(cros_devs), >> >> + if (IS_ENABLED(CONFIG_OF) && dev->of_node) >> >> + ec_p.

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Lee Jones
On Wed, 03 Jun 2015, Javier Martinez Canillas wrote: > Hello Lee, > > Thanks a lot for your feedback. > > On 06/03/2015 10:53 AM, Lee Jones wrote: > > On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: > > > >> From: Gwendal Grignou > >> > >> Chromebooks can have more than one Embedded Cont

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 06/03/2015 10:53 AM, Lee Jones wrote: > On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: > >> From: Gwendal Grignou >> >> Chromebooks can have more than one Embedded Controller so the >> cros_ec device id has to be incremented for each EC regis

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Lee Jones
On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: > From: Gwendal Grignou > > Chromebooks can have more than one Embedded Controller so the > cros_ec device id has to be incremented for each EC registered. > > Add code to handle multiple EC. First ec found is cros-ec0, > second cros-ec1 and