RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-02-06 Thread Patil, Rachna
Hi Koen, > > > > > Since AM335x is DT only, why is there a platform data codepath and why > > > > is it the first branch it tries? And I guess the next question is > > > > related to the first: why doesn't it work when used with DT? When I > > > > copy over the nodes from the evm.dts to my boa

RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-31 Thread Patil, Rachna
Vaibhav, > > > > > > > > - if (!pdata) { > > > > + if (!pdata && !pdev->dev.of_node) { > > > > dev_err(&pdev->dev, "Could not find platform data\n"); > > > > return -EINVAL; > > > > } > > > > > > > > - if (pdata->adc_init) > > > > -

RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-30 Thread Hiremath, Vaibhav
On Thu, Jan 31, 2013 at 09:41:11, Patil, Rachna wrote: > On Wed, Jan 30, 2013 at 16:10:09, Koen Kooi wrote: > > > > Op 24 jan. 2013, om 04:45 heeft "Patil, Rachna" het > > volgende geschreven: > > > > > From: "Patil, Rachna" > > > > > > Make changes to add DT support in the MFD core driver. >

RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-30 Thread Patil, Rachna
On Wed, Jan 30, 2013 at 16:10:09, Koen Kooi wrote: > > Op 24 jan. 2013, om 04:45 heeft "Patil, Rachna" het volgende > geschreven: > > > From: "Patil, Rachna" > > > > Make changes to add DT support in the MFD core driver. > > > > Signed-off-by: Patil, Rachna > > --- > > Changes in v4: > >

Re: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-30 Thread Koen Kooi
Op 24 jan. 2013, om 04:45 heeft "Patil, Rachna" het volgende geschreven: > From: "Patil, Rachna" > > Make changes to add DT support in the MFD core driver. > > Signed-off-by: Patil, Rachna > --- > Changes in v4: > Non-standard properties prefixed with vendor name. > > drivers/mfd/ti_