Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2015-03-31 Thread Greg Kroah-Hartman
On Fri, Mar 27, 2015 at 08:46:57AM +0100, Daniel Vetter wrote: > On Thu, Mar 26, 2015 at 11:05:45PM +0200, Imre Deak wrote: > > On Thu, 2015-03-26 at 22:01 +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > > > > On 12/16/2014 09:42 AM, Daniel Vet

Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2015-03-27 Thread Daniel Vetter
On Thu, Mar 26, 2015 at 11:05:45PM +0200, Imre Deak wrote: > On Thu, 2015-03-26 at 22:01 +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > > > On 12/16/2014 09:42 AM, Daniel Vetter wrote: > > > > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley > > >

Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2015-03-26 Thread Imre Deak
On Thu, 2015-03-26 at 22:01 +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > > On 12/16/2014 09:42 AM, Daniel Vetter wrote: > > > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley > > > wrote: > > >> On 12/16/2014 11:22 AM, Imre Deak wrote: > > >>> On

Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2015-03-26 Thread Greg Kroah-Hartman
On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > On 12/16/2014 09:42 AM, Daniel Vetter wrote: > > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley > > wrote: > >> On 12/16/2014 11:22 AM, Imre Deak wrote: > >>> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: > Fine. Just an

Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2015-03-26 Thread Jesse Barnes
On 12/16/2014 09:42 AM, Daniel Vetter wrote: > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley > wrote: >> On 12/16/2014 11:22 AM, Imre Deak wrote: >>> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: Fine. Just another expedient fix piled on top of other expedient fixes that go bac

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Daniel Vetter
On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley wrote: > On 12/16/2014 11:22 AM, Imre Deak wrote: >> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: >>> Fine. Just another expedient fix piled on top of other expedient fixes >>> that go back past 3.9 with no end in sight. >> >> I'm also happy

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Peter Hurley
On 12/16/2014 11:22 AM, Imre Deak wrote: > On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: >> Fine. Just another expedient fix piled on top of other expedient fixes >> that go back past 3.9 with no end in sight. > > I'm also happy to look into narrowing down the scope of console_lock in >

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Imre Deak
On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: > On 12/16/2014 09:38 AM, Imre Deak wrote: > > On Tue, 2014-12-16 at 07:50 -0500, Peter Hurley wrote: > >> On 12/16/2014 05:23 AM, Imre Deak wrote: > >>> On Tue, 2014-12-16 at 08:53 +0100, Daniel Vetter wrote: > On Tue, Dec 16, 2014 at 12:

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Peter Hurley
On 12/16/2014 10:10 AM, Daniel Vetter wrote: > On Tue, Dec 16, 2014 at 4:00 PM, Peter Hurley > wrote: >>> The fix will be anyway the same in principal even after Daniel's planned >>> rework for fbcon/fbdev: not holding the console_lock while freeing the >>> sysfs entries. >> >> Oh, I didn't know

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Daniel Vetter
On Tue, Dec 16, 2014 at 4:00 PM, Peter Hurley wrote: >> The fix will be anyway the same in principal even after Daniel's planned >> rework for fbcon/fbdev: not holding the console_lock while freeing the >> sysfs entries. > > Oh, I didn't know Daniel was planning to rework fbcon/fbdev. I don't. I'

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Peter Hurley
On 12/16/2014 09:38 AM, Imre Deak wrote: > On Tue, 2014-12-16 at 07:50 -0500, Peter Hurley wrote: >> On 12/16/2014 05:23 AM, Imre Deak wrote: >>> On Tue, 2014-12-16 at 08:53 +0100, Daniel Vetter wrote: On Tue, Dec 16, 2014 at 12:16:01AM +0200, Imre Deak wrote: > Currently there is a lock o

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Imre Deak
On Tue, 2014-12-16 at 07:50 -0500, Peter Hurley wrote: > On 12/16/2014 05:23 AM, Imre Deak wrote: > > On Tue, 2014-12-16 at 08:53 +0100, Daniel Vetter wrote: > >> On Tue, Dec 16, 2014 at 12:16:01AM +0200, Imre Deak wrote: > >>> Currently there is a lock order problem between the console lock and th

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Daniel Vetter
On Tue, Dec 16, 2014 at 1:50 PM, Peter Hurley wrote: >>> So NACK from me for this. >> >> I think I proved it in the commit message that this issue is independent >> of fbcon/fbdev, so refactoring these will not solve it. This patch fixes >> an issue in vt and while your points may be valid, they a

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Peter Hurley
On 12/16/2014 05:23 AM, Imre Deak wrote: > On Tue, 2014-12-16 at 08:53 +0100, Daniel Vetter wrote: >> On Tue, Dec 16, 2014 at 12:16:01AM +0200, Imre Deak wrote: >>> Currently there is a lock order problem between the console lock and the >>> kernfs s_active lock of the console driver's bind sysfs e

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-16 Thread Imre Deak
On Tue, 2014-12-16 at 08:53 +0100, Daniel Vetter wrote: > On Tue, Dec 16, 2014 at 12:16:01AM +0200, Imre Deak wrote: > > Currently there is a lock order problem between the console lock and the > > kernfs s_active lock of the console driver's bind sysfs entry. When > > writing to the sysfs entry th

Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order

2014-12-15 Thread Daniel Vetter
On Tue, Dec 16, 2014 at 12:16:01AM +0200, Imre Deak wrote: > Currently there is a lock order problem between the console lock and the > kernfs s_active lock of the console driver's bind sysfs entry. When > writing to the sysfs entry the lock order is first s_active then console > lock, when unregis