Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-19 Thread Rob Herring
On Fri, Sep 16, 2016 at 7:05 PM, Stephen Boyd wrote: > Quoting Rob Herring (2016-09-16 08:19:51) >> On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: >> > The high-speed phy on qcom SoCs is controlled via the ULPI >> > viewport. >> > [...] >> > +- qcom,init-seq: >> > +Usage: opti

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-16 Thread Rob Herring
On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > The high-speed phy on qcom SoCs is controlled via the ULPI > viewport. > > Cc: Kishon Vijay Abraham I > Cc: > Signed-off-by: Stephen Boyd > --- > .../devicetree/bindings/phy/qcom,usb-hs-phy.txt| 83 ++ > drivers/phy/Kconf

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-14 Thread Peter Chen
On Wed, Sep 14, 2016 at 10:42:50AM -0700, Stephen Boyd wrote: > > > > > > Hmm.. maybe the confusion is in which registers we should be able to > > > access? Are we talking about the ULPI viewport MMIO register space or > > > the ULPI registers that we access through the viewport? I have a > > > hw

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-14 Thread Peter Chen
On Tue, Sep 13, 2016 at 11:29:12PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-13 19:11:33) > > On Tue, Sep 13, 2016 at 01:41:44PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-13 00:03:58) > > > > On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > > > > > T

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-13 Thread Kishon Vijay Abraham I
On Saturday 10 September 2016 05:48 PM, Kishon Vijay Abraham I wrote: > > On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: >> The high-speed phy on qcom SoCs is controlled via the ULPI >> viewport. >> >> Cc: Kishon Vijay Abraham I >> Cc: >> Signed-off-by: Stephen Boyd > > merged

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-13 Thread Peter Chen
On Tue, Sep 13, 2016 at 01:41:44PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-13 00:03:58) > > On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > > > The high-speed phy on qcom SoCs is controlled via the ULPI > > > viewport. > > > > > > > Hi Stephen, I am a little puzzl

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-13 Thread Peter Chen
On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > The high-speed phy on qcom SoCs is controlled via the ULPI > viewport. > Hi Stephen, I am a little puzzled how this driver co-work with chipidea driver. According to nxp IC guys, the ULPI PHY's clock needs to be enabled before access