Re: [PATCH v4 2/2] lib/test-string_helpers.c: add string_get_size() tests

2015-09-16 Thread Vitaly Kuznetsov
Andy Shevchenko writes: > On Wed, 2015-09-16 at 13:21 +0200, Rasmus Villemoes wrote: >> On Tue, Sep 15 2015, Andy Shevchenko < >> andriy.shevche...@linux.intel.com> wrote: >> >> > On Tue, 2015-09-15 at 15:55 +0200, Vitaly Kuznetsov wrote: >> > > +static __init void test_string_get_size_one(u64 s

Re: [PATCH v4 2/2] lib/test-string_helpers.c: add string_get_size() tests

2015-09-16 Thread Andy Shevchenko
On Wed, 2015-09-16 at 13:21 +0200, Rasmus Villemoes wrote: > On Tue, Sep 15 2015, Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > > On Tue, 2015-09-15 at 15:55 +0200, Vitaly Kuznetsov wrote: > > > +static __init void test_string_get_size_one(u64 size, u64 > > > blk_size, > > > +

Re: [PATCH v4 2/2] lib/test-string_helpers.c: add string_get_size() tests

2015-09-16 Thread Rasmus Villemoes
On Tue, Sep 15 2015, Andy Shevchenko wrote: > On Tue, 2015-09-15 at 15:55 +0200, Vitaly Kuznetsov wrote: >> +static __init void test_string_get_size_one(u64 size, u64 blk_size, >> +const enum >> string_size_units units, >> +

Re: [PATCH v4 2/2] lib/test-string_helpers.c: add string_get_size() tests

2015-09-15 Thread Andy Shevchenko
On Tue, 2015-09-15 at 15:55 +0200, Vitaly Kuznetsov wrote: > Add a couple of simple tests for string_get_size(). The last one will > hang > the kernel without the 'lib/string_helpers.c: fix infinite loop in > string_get_size()' fix. > Minor comments to address, otherwise Reviewed-by: Andy Shev