Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-05-14 Thread Vlastimil Babka
On 5/7/25 01:14, Suren Baghdasaryan wrote: > On Fri, Apr 25, 2025 at 1:27 AM Vlastimil Babka wrote: >> >> Signed-off-by: Vlastimil Babka > > Reviewed-by: Suren Baghdasaryan Thanks! > One nit which is barely worth mentioning. OK, made the change.

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-05-13 Thread Vlastimil Babka
On 4/29/25 03:08, Harry Yoo wrote: > On Fri, Apr 25, 2025 at 10:27:21AM +0200, Vlastimil Babka wrote: >> Specifying a non-zero value for a new struct kmem_cache_args field >> sheaf_capacity will setup a caching layer of percpu arrays called >> sheaves of given capacity for the created cache. >> >>

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-05-06 Thread Suren Baghdasaryan
On Fri, Apr 25, 2025 at 1:27 AM Vlastimil Babka wrote: > > Specifying a non-zero value for a new struct kmem_cache_args field > sheaf_capacity will setup a caching layer of percpu arrays called > sheaves of given capacity for the created cache. > > Allocations from the cache will allocate via the

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-05-06 Thread Suren Baghdasaryan
On Tue, May 6, 2025 at 10:32 AM Suren Baghdasaryan wrote: > > On Mon, Apr 28, 2025 at 12:01 AM Vlastimil Babka wrote: > > > > On 4/25/25 19:31, Christoph Lameter (Ampere) wrote: > > > On Fri, 25 Apr 2025, Vlastimil Babka wrote: > > > > > >> @@ -4195,7 +4793,11 @@ static __fastpath_inline void >

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-05-06 Thread Suren Baghdasaryan
On Mon, Apr 28, 2025 at 12:01 AM Vlastimil Babka wrote: > > On 4/25/25 19:31, Christoph Lameter (Ampere) wrote: > > On Fri, 25 Apr 2025, Vlastimil Babka wrote: > > > >> @@ -4195,7 +4793,11 @@ static __fastpath_inline void > >> *slab_alloc_node(struct kmem_cache *s, struct list > >> if (unlik

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-04-28 Thread Harry Yoo
On Fri, Apr 25, 2025 at 10:27:21AM +0200, Vlastimil Babka wrote: > Specifying a non-zero value for a new struct kmem_cache_args field > sheaf_capacity will setup a caching layer of percpu arrays called > sheaves of given capacity for the created cache. > > Allocations from the cache will allocate

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-04-28 Thread Vlastimil Babka
On 4/25/25 19:31, Christoph Lameter (Ampere) wrote: > On Fri, 25 Apr 2025, Vlastimil Babka wrote: > >> @@ -4195,7 +4793,11 @@ static __fastpath_inline void *slab_alloc_node(struct >> kmem_cache *s, struct list >> if (unlikely(object)) >> goto out; >> >> -object = __slab_allo

Re: [PATCH v4 1/9] slab: add opt-in caching layer of percpu sheaves

2025-04-25 Thread Christoph Lameter (Ampere)
On Fri, 25 Apr 2025, Vlastimil Babka wrote: > @@ -4195,7 +4793,11 @@ static __fastpath_inline void *slab_alloc_node(struct > kmem_cache *s, struct list > if (unlikely(object)) > goto out; > > - object = __slab_alloc_node(s, gfpflags, node, addr, orig_size); > + if (s->