Re: [PATCH v4 1/5] ARM: add basic Trusted Foundations support

2013-09-03 Thread Stephen Warren
On 08/29/2013 03:57 AM, Alexandre Courbot wrote: > Trusted Foundations is a TrustZone-based secure monitor for ARM that > can be invoked using a consistent smc-based API on all supported Nit: s/smc/SMC/? > diff --git a/arch/arm/include/asm/trusted_foundations.h > b/arch/arm/include/asm/trusted_

Re: [PATCH v4 1/5] ARM: add basic Trusted Foundations support

2013-09-03 Thread Stephen Warren
On 09/02/2013 01:28 AM, Alexandre Courbot wrote: > Hi Tomasz! > > On Fri, Aug 30, 2013 at 5:20 PM, Tomasz Figa wrote: >>> +Required properties: >>> +- compatible : "tl,trusted-foundations" >>> +- version-major : major version number of Trusted Foundations firmware >>> +- version-minor: minor vers

Re: [PATCH v4 1/5] ARM: add basic Trusted Foundations support

2013-09-02 Thread Alexandre Courbot
Hi Tomasz! On Fri, Aug 30, 2013 at 5:20 PM, Tomasz Figa wrote: >> +Required properties: >> +- compatible : "tl,trusted-foundations" >> +- version-major : major version number of Trusted Foundations firmware >> +- version-minor: minor version number of Trusted Foundations firmware > > Hmm, maybe y

Re: [PATCH v4 1/5] ARM: add basic Trusted Foundations support

2013-08-30 Thread Tomasz Figa
Hi Alexandre, Overall this looks good to me, but I have some minor comments. On Thursday 29 of August 2013 18:57:44 Alexandre Courbot wrote: > Trusted Foundations is a TrustZone-based secure monitor for ARM that > can be invoked using a consistent smc-based API on all supported > platforms. This