Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi! > >> explain to me again why this is useful? > > > > The official binding for providing the BD_ADDR through the device tree > > is the property 'local-bd-address'. device_get_bd_address() provides a > > common API to retrieve the BD_ADDR instead of requiring BT drivers to > > use the lower le

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi Marcel, On Tue, Oct 16, 2018 at 08:52:07AM +0200, Marcel Holtmann wrote: > Hi Matthias, > > >> void bt_sock_reclassify_lock(struct sock *sk, int proto); > >> > >> +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); > > > > Maybe change the API name to start

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi Matthias, >> void bt_sock_reclassify_lock(struct sock *sk, int proto); >> >> +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); > > Maybe change the API name to start with bt_ and get rid of device_? device_ indicates that we get the BD_ADDR for

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

On Mon, Oct 15, 2018 at 08:06:02PM +0200, Marcel Holtmann wrote: > Hi Matthias, > > void bt_sock_reclassify_lock(struct sock *sk, int proto); > > +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); > >>> > >>> Maybe change the API name to start with bt_ and get rid

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi Matthias, void bt_sock_reclassify_lock(struct sock *sk, int proto); +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); >>> >>> Maybe change the API name to start with bt_ and get rid of device_? >> >> device_ indicates that we get the BD_ADDR for a 'struct dev

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi Marcel, please let me know if any changes are needed to get this patch applied to bluetooth-next. Thanks Matthias On Thu, Oct 04, 2018 at 10:33:38AM -0700, Matthias Kaehlcke wrote: > On Thu, Sep 27, 2018 at 10:13:05AM -0700, Matthias Kaehlcke wrote: > > On Thu, Sep 27, 2018 at 12:47:06PM -04

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

On Thu, Sep 27, 2018 at 10:13:05AM -0700, Matthias Kaehlcke wrote: > On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote: > > On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote: > > >  void bt_sock_reclassify_lock(struct sock *sk, int proto); > > > > > > +int device_get_bd_address(struct 

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote: > On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote: > >  void bt_sock_reclassify_lock(struct sock *sk, int proto); > > > > +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); > > Maybe change the API name to start with

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote:  void bt_sock_reclassify_lock(struct sock *sk, int proto); +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr); Maybe change the API name to start with bt_ and get rid of device_?

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

Hi Matthias, On 2018-09-27 06:18, Matthias Kaehlcke wrote: Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the firmware node of the device has a property 'local-bd-address' the BD address is read from this property. Signed-off-by: Matthia

Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

On Wed, Sep 26, 2018 at 05:48:09PM -0700, Matthias Kaehlcke wrote: > Provide an API for Bluetooth drivers to retrieve the Bluetooth Device > address (BD_ADDR) for a device. If the firmware node of the device > has a property 'local-bd-address' the BD address is read from this > property. > > Signe