Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-28 Thread atull
On Thu, 28 May 2015, Dinh Nguyen wrote: > On 05/27/2015 03:25 PM, atull wrote: > > On Tue, 26 May 2015, Dinh Nguyen wrote: > > > >> Hi Alan, > >> > >> On 5/22/15 1:02 PM, Alan Tull wrote: > >>> Add code that requests that the sdr controller go into > >>> self-refresh mode. This code is run from

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-28 Thread atull
On Tue, 26 May 2015, Pavel Machek wrote: > Hi! > > > Thanks for the feedback. > > > > Yes I agree. > > > > One possibility is that I could add a suspend function to EDAC that > > always fails with a helpful message like "Suspend with EDAC not > > supported." If someone wants to suspend, they'l

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-28 Thread Dinh Nguyen
On 05/27/2015 03:25 PM, atull wrote: > On Tue, 26 May 2015, Dinh Nguyen wrote: > >> Hi Alan, >> >> On 5/22/15 1:02 PM, Alan Tull wrote: >>> Add code that requests that the sdr controller go into >>> self-refresh mode. This code is run from ocram. >>> >>> This patch assumes that u-boot has already

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-27 Thread atull
On Tue, 26 May 2015, Dinh Nguyen wrote: > Hi Alan, > > On 5/22/15 1:02 PM, Alan Tull wrote: > > Add code that requests that the sdr controller go into > > self-refresh mode. This code is run from ocram. > > > > This patch assumes that u-boot has already configured sdr: > > sdr.ctrlcfg.lowpwre

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-26 Thread Pavel Machek
Hi! > Thanks for the feedback. > > Yes I agree. > > One possibility is that I could add a suspend function to EDAC that > always fails with a helpful message like "Suspend with EDAC not > supported." If someone wants to suspend, they'll have to take the > EDAC out of the device tree so its prob

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-26 Thread atull
On Mon, 25 May 2015, Pavel Machek wrote: > Hi! > > > Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA > > platforms. CONFIG_SOCFPGA_SUSPEND enables suspend-to-RAM and > > prevents selecting CONFIG_EDAC_ALTERA_MC. > > Do we went to have the dependency at the .config time? We wou

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-26 Thread Dinh Nguyen
Hi Alan, On 5/22/15 1:02 PM, Alan Tull wrote: > Add code that requests that the sdr controller go into > self-refresh mode. This code is run from ocram. > > This patch assumes that u-boot has already configured sdr: > sdr.ctrlcfg.lowpwreq.selfrfshmask = 3 > sdr.ctrlcfg.lowpwrtiming.clkdisabl

Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram

2015-05-25 Thread Pavel Machek
Hi! > Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA > platforms. CONFIG_SOCFPGA_SUSPEND enables suspend-to-RAM and > prevents selecting CONFIG_EDAC_ALTERA_MC. Do we went to have the dependency at the .config time? We would like to do generic kernels booting on many machines,