Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 9:44 PM Michael Walle wrote: > Am 2020-06-05 15:15, schrieb Andy Shevchenko: > > On Fri, Jun 05, 2020 at 02:42:53PM +0200, Michael Walle wrote: > >> Am 2020-06-05 14:00, schrieb Andy Shevchenko: > >> > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >> > > +

Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Michael Walle
Am 2020-06-05 15:15, schrieb Andy Shevchenko: On Fri, Jun 05, 2020 at 02:42:53PM +0200, Michael Walle wrote: Am 2020-06-05 14:00, schrieb Andy Shevchenko: > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > > + return devm_regmap_add_irq_chip_np(dev, dev_of_node(dev), > > regmap,

Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 05, 2020 at 02:42:53PM +0200, Michael Walle wrote: > Am 2020-06-05 14:00, schrieb Andy Shevchenko: > > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > > > + return devm_regmap_add_irq_chip_np(dev, dev_of_node(dev), > > > regmap, > > > > It seems regmap needs to be conver

Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Michael Walle
Am 2020-06-05 14:00, schrieb Andy Shevchenko: On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: Add support for the GPIO controller of the sl28 board management controller. This driver is part of a multi-function device. A controller has 8 lines. There are three different flavors: full-fea

Re: [PATCH v4 06/11] gpio: add support for the sl28cpld GPIO controller

2020-06-05 Thread Andy Shevchenko
On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > Add support for the GPIO controller of the sl28 board management > controller. This driver is part of a multi-function device. > > A controller has 8 lines. There are three different flavors: > full-featured GPIO with interrupt support, input