Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-24 Thread Cornelia Huck
On Tue, 24 Apr 2018 09:01:12 -0400 Tony Krowiak wrote: > On 04/23/2018 03:03 AM, Cornelia Huck wrote: > > On Sun, 22 Apr 2018 10:52:55 -0400 > > Tony Krowiak wrote: > > > >>> (Not providing a crycb if APXA is not available would be loss of > >>> functionality, I guess? Deciding not to

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-24 Thread Tony Krowiak
On 04/23/2018 03:03 AM, Cornelia Huck wrote: On Sun, 22 Apr 2018 10:52:55 -0400 Tony Krowiak wrote: (Not providing a crycb if APXA is not available would be loss of functionality, I guess? Deciding not to provide vfio-ap if APXA is not available is a different game, of course.) This would req

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-23 Thread Cornelia Huck
On Sun, 22 Apr 2018 10:52:55 -0400 Tony Krowiak wrote: > > (Not providing a crycb if APXA is not available would be loss of > > functionality, I guess? Deciding not to provide vfio-ap if APXA is not > > available is a different game, of course.) > This would require a change to

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-22 Thread Tony Krowiak
On 04/17/2018 11:52 AM, Pierre Morel wrote: On 17/04/2018 16:15, Tony Krowiak wrote: On 04/16/2018 04:56 AM, Pierre Morel wrote: On 15/04/2018 23:22, Tony Krowiak wrote: This patch refactors the code that initializes the crypto configuration for a guest. The crypto configuration is contained i

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-22 Thread Tony Krowiak
On 04/18/2018 03:49 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 14:08:59 -0400 Tony Krowiak wrote: On 04/17/2018 11:21 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 10:26:57 -0400 Tony Krowiak wrote: On 04/17/2018 06:10 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 09:49:58 +0200 "Harald

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-18 Thread Cornelia Huck
On Tue, 17 Apr 2018 14:08:59 -0400 Tony Krowiak wrote: > On 04/17/2018 11:21 AM, Cornelia Huck wrote: > > On Tue, 17 Apr 2018 10:26:57 -0400 > > Tony Krowiak wrote: > > > >> On 04/17/2018 06:10 AM, Cornelia Huck wrote: > >>> On Tue, 17 Apr 2018 09:49:58 +0200 > >>> "Harald Freudenberger" wr

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Tony Krowiak
On 04/17/2018 11:21 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 10:26:57 -0400 Tony Krowiak wrote: On 04/17/2018 06:10 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 09:49:58 +0200 "Harald Freudenberger" wrote: Didn't we say that when APXA is not available there is no Crypto support for K

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Pierre Morel
On 17/04/2018 16:15, Tony Krowiak wrote: On 04/16/2018 04:56 AM, Pierre Morel wrote: On 15/04/2018 23:22, Tony Krowiak wrote: This patch refactors the code that initializes the crypto configuration for a guest. The crypto configuration is contained in a crypto control block (CRYCB) which is a s

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Cornelia Huck
On Tue, 17 Apr 2018 10:26:57 -0400 Tony Krowiak wrote: > On 04/17/2018 06:10 AM, Cornelia Huck wrote: > > On Tue, 17 Apr 2018 09:49:58 +0200 > > "Harald Freudenberger" wrote: > > > >> Didn't we say that when APXA is not available there is no Crypto support > >> for KVM ? > > [Going by the co

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Tony Krowiak
On 04/15/2018 05:22 PM, Tony Krowiak wrote: This patch refactors the code that initializes the crypto configuration for a guest. The crypto configuration is contained in a crypto control block (CRYCB) which is a satellite control block to our main hardware virtualization control block. The CRYCB

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Tony Krowiak
On 04/17/2018 06:10 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 09:49:58 +0200 "Harald Freudenberger" wrote: Didn't we say that when APXA is not available there is no Crypto support for KVM ? [Going by the code, as I don't have access to the architecture] Current status seems to be: - setup

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Tony Krowiak
On 04/16/2018 04:56 AM, Pierre Morel wrote: On 15/04/2018 23:22, Tony Krowiak wrote: This patch refactors the code that initializes the crypto configuration for a guest. The crypto configuration is contained in a crypto control block (CRYCB) which is a satellite control block to our main hardwar

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-17 Thread Cornelia Huck
On Tue, 17 Apr 2018 09:49:58 +0200 "Harald Freudenberger" wrote: > Didn't we say that when APXA is not available there is no Crypto support > for KVM ? [Going by the code, as I don't have access to the architecture] Current status seems to be: - setup crycb if facility 76 is available (that's M

Re: [PATCH v4 03/15] KVM: s390: refactor crypto initialization

2018-04-16 Thread Pierre Morel
On 15/04/2018 23:22, Tony Krowiak wrote: This patch refactors the code that initializes the crypto configuration for a guest. The crypto configuration is contained in a crypto control block (CRYCB) which is a satellite control block to our main hardware virtualization control block. The CRYCB is