Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

On 17. 04. 19, 8:52, Jiri Slaby wrote: > So could you rework the patch to remove only the one? And in a separate > patch, introduce a printk_ratelimited warning to every "case *:" (i.e. Not printk_ratelimited, but "dev_warn_ratelimited(tty->dev" as we have a device. > no warning in the "default"

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

On 17. 04. 19, 8:46, Greg Kroah-Hartman wrote: > On Wed, Apr 17, 2019 at 08:27:41AM +0200, Jiri Slaby wrote: >> On 16. 04. 19, 16:53, Fuqian Huang wrote: >>> --- a/drivers/tty/rocket.c >>> +++ b/drivers/tty/rocket.c >> ... >>> -/* IOCTL call handler into the driver */ >>> -static int rp_ioctl(stru

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

On Wed, Apr 17, 2019 at 08:27:41AM +0200, Jiri Slaby wrote: > On 16. 04. 19, 16:53, Fuqian Huang wrote: > > --- a/drivers/tty/rocket.c > > +++ b/drivers/tty/rocket.c > ... > > -/* IOCTL call handler into the driver */ > > -static int rp_ioctl(struct tty_struct *tty, > > - unsigned in

Re: [PATCH v4] tty: rocket: Remove the rp_ioctl

On 16. 04. 19, 16:53, Fuqian Huang wrote: > --- a/drivers/tty/rocket.c > +++ b/drivers/tty/rocket.c ... > -/* IOCTL call handler into the driver */ > -static int rp_ioctl(struct tty_struct *tty, > - unsigned int cmd, unsigned long arg) > -{ > - struct r_port *info = tty->driver