Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-08 Thread kbuild test robot
Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc5] [cannot apply to next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-07 Thread Serge E. Hallyn
On Fri, Dec 07, 2018 at 02:54:25AM +0100, Christian Brauner wrote: > On Thu, Dec 06, 2018 at 05:39:18PM -0800, Daniel Colascione wrote: > > On Thu, Dec 6, 2018 at 4:59 PM Serge E. Hallyn wrote: > > > > > > On Thu, Dec 06, 2018 at 04:34:54PM -0800, Daniel Colascione wrote: > > > > On Thu, Dec 6, 20

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-07 Thread Serge E. Hallyn
On Thu, Dec 06, 2018 at 01:18:58PM +0100, Christian Brauner wrote: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 05:39:18PM -0800, Daniel Colascione wrote: > On Thu, Dec 6, 2018 at 4:59 PM Serge E. Hallyn wrote: > > > > On Thu, Dec 06, 2018 at 04:34:54PM -0800, Daniel Colascione wrote: > > > On Thu, Dec 6, 2018 at 4:31 PM Serge E. Hallyn wrote: > > > > > > > > On Fri, Dec 07, 2018 at

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 4:59 PM Serge E. Hallyn wrote: > > On Thu, Dec 06, 2018 at 04:34:54PM -0800, Daniel Colascione wrote: > > On Thu, Dec 6, 2018 at 4:31 PM Serge E. Hallyn wrote: > > > > > > On Fri, Dec 07, 2018 at 12:17:45AM +0100, Christian Brauner wrote: > > > > On Thu, Dec 06, 2018 at 11:

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Serge E. Hallyn
On Thu, Dec 06, 2018 at 04:34:54PM -0800, Daniel Colascione wrote: > On Thu, Dec 6, 2018 at 4:31 PM Serge E. Hallyn wrote: > > > > On Fri, Dec 07, 2018 at 12:17:45AM +0100, Christian Brauner wrote: > > > On Thu, Dec 06, 2018 at 11:39:48PM +0100, Christian Brauner wrote: > > > > On Thu, Dec 06, 201

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 4:31 PM Serge E. Hallyn wrote: > > On Fri, Dec 07, 2018 at 12:17:45AM +0100, Christian Brauner wrote: > > On Thu, Dec 06, 2018 at 11:39:48PM +0100, Christian Brauner wrote: > > > On Thu, Dec 06, 2018 at 03:46:53PM -0600, Eric W. Biederman wrote: > > > > Christian Brauner wr

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Serge E. Hallyn
On Fri, Dec 07, 2018 at 12:17:45AM +0100, Christian Brauner wrote: > On Thu, Dec 06, 2018 at 11:39:48PM +0100, Christian Brauner wrote: > > On Thu, Dec 06, 2018 at 03:46:53PM -0600, Eric W. Biederman wrote: > > > Christian Brauner writes: > > > > > > >> Your intention is to add the thread case to

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 11:39:48PM +0100, Christian Brauner wrote: > On Thu, Dec 06, 2018 at 03:46:53PM -0600, Eric W. Biederman wrote: > > Christian Brauner writes: > > > > >> Your intention is to add the thread case to support pthreads once the > > >> process case is sorted out. So this is som

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 2:22 PM Eric W. Biederman wrote: > > Daniel Colascione writes: > > > On Thu, Dec 6, 2018 at 12:29 PM Eric W. Biederman > > wrote: > >> Christian Brauner writes: > >> > >> > [1]: You cannot replicate certain aspects of kill *yet*. We have > >> > established this before. I

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 03:46:53PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > >> Your intention is to add the thread case to support pthreads once the > >> process case is sorted out. So this is something that needs to be made > >> clear. Did I miss how you plan to handle t

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Serge E. Hallyn
On Thu, Dec 06, 2018 at 10:30:40AM -0800, Kees Cook wrote: > On Thu, Dec 6, 2018 at 9:41 AM Christian Brauner wrote: > > I feel changing the name around by a single persons preferences is not > > really a nice thing to do community-wise. So I'd like to hear other > > people chime in first before I

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Daniel Colascione writes: > On Thu, Dec 6, 2018 at 12:29 PM Eric W. Biederman > wrote: >> Christian Brauner writes: >> >> > [1]: You cannot replicate certain aspects of kill *yet*. We have >> > established this before. If we want process group support later we do >> > have the flags argument t

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 1:47 PM Eric W. Biederman wrote: > > Christian Brauner writes: > > >> Your intention is to add the thread case to support pthreads once the > >> process case is sorted out. So this is something that needs to be made > >> clear. Did I miss how you plan to handle threads? >

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Christian Brauner writes: >> Your intention is to add the thread case to support pthreads once the >> process case is sorted out. So this is something that needs to be made >> clear. Did I miss how you plan to handle threads? > > Yeah, maybe you missed it in the commit message [2] which is base

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 02:29:13PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Thu, Dec 06, 2018 at 01:17:24PM -0600, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: > >> >>Christ

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 12:29 PM Eric W. Biederman wrote: > Christian Brauner writes: > > > On Thu, Dec 06, 2018 at 01:17:24PM -0600, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: > >> >>Christian Brauner

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Christian Brauner writes: > On Thu, Dec 06, 2018 at 01:17:24PM -0600, Eric W. Biederman wrote: >> Christian Brauner writes: >> >> > On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: >> >>Christian Brauner writes: >> >> >> >>> The kill() syscall operates on process identifi

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 01:17:24PM -0600, Eric W. Biederman wrote: > Christian Brauner writes: > > > On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: > >>Christian Brauner writes: > >> > >>> The kill() syscall operates on process identifiers (pid). After a > >>process > >>>

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Christian Brauner writes: > On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: >>Christian Brauner writes: >> >>> The kill() syscall operates on process identifiers (pid). After a >>process >>> has exited its pid can be reused by another process. If a caller >>sends a >>> sig

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Kees Cook
On Thu, Dec 6, 2018 at 9:41 AM Christian Brauner wrote: > I feel changing the name around by a single persons preferences is not > really a nice thing to do community-wise. So I'd like to hear other > people chime in first before I make that change. I don't think the name is hugely critical (but

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 11:24:28AM -0600, Eric W. Biederman wrote: > Daniel Colascione writes: > > > On Thu, Dec 6, 2018 at 7:02 AM Eric W. Biederman > > wrote: > >> > >> Christian Brauner writes: > >> > >> > The kill() syscall operates on process identifiers (pid). After a process > >> > has

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Daniel Colascione writes: > On Thu, Dec 6, 2018 at 7:02 AM Eric W. Biederman > wrote: >> >> Christian Brauner writes: >> >> > The kill() syscall operates on process identifiers (pid). After a process >> > has exited its pid can be reused by another process. If a caller sends a >> > signal to a

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On December 7, 2018 4:01:19 AM GMT+13:00, ebied...@xmission.com wrote: >Christian Brauner writes: > >> The kill() syscall operates on process identifiers (pid). After a >process >> has exited its pid can be reused by another process. If a caller >sends a >> signal to a reused pid it will end up si

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Daniel Colascione
On Thu, Dec 6, 2018 at 7:02 AM Eric W. Biederman wrote: > > Christian Brauner writes: > > > The kill() syscall operates on process identifiers (pid). After a process > > has exited its pid can be reused by another process. If a caller sends a > > signal to a reused pid it will end up signaling th

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Christian Brauner writes: > The kill() syscall operates on process identifiers (pid). After a process > has exited its pid can be reused by another process. If a caller sends a > signal to a reused pid it will end up signaling the wrong process. This > issue has often surfaced and there has been

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Florian Weimer writes: > * Eric W. Biederman: > >> Floriam are you seeing a problem with this behavior or the way Christian >> was describing it? > > My hope is that you could use taskfd_send_signal one day to send a > signal to a process which you *known* (based on how you've written your > appl

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Aleksa Sarai
On 2018-12-06, Florian Weimer wrote: > > Floriam are you seeing a problem with this behavior or the way Christian > > was describing it? > > My hope is that you could use taskfd_send_signal one day to send a > signal to a process which you *known* (based on how you've written your > application)

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Florian Weimer
* Eric W. Biederman: > Floriam are you seeing a problem with this behavior or the way Christian > was describing it? My hope is that you could use taskfd_send_signal one day to send a signal to a process which you *known* (based on how you've written your application) should be running and not in

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Eric W. Biederman
Florian Weimer writes: > * Jürg Billeter: > >> On Thu, 2018-12-06 at 13:30 +0100, Florian Weimer wrote: >>> * Christian Brauner: >>> >>> > /* zombies */ >>> > Zombies can be signaled just as any other process. No special error will >>> > be >>> > reported since a zombie state is an unreliable s

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Florian Weimer
* Jürg Billeter: > On Thu, 2018-12-06 at 14:12 +0100, Florian Weimer wrote: >> * Jürg Billeter: >> >> > On Thu, 2018-12-06 at 13:30 +0100, Florian Weimer wrote: >> > > * Christian Brauner: >> > > >> > > > /* zombies */ >> > > > Zombies can be signaled just as any other process. No special error

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Jürg Billeter
On Thu, 2018-12-06 at 14:12 +0100, Florian Weimer wrote: > * Jürg Billeter: > > > On Thu, 2018-12-06 at 13:30 +0100, Florian Weimer wrote: > > > * Christian Brauner: > > > > > > > /* zombies */ > > > > Zombies can be signaled just as any other process. No special error > > > > will be > > > > re

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Florian Weimer
* Christian Brauner: > On Thu, Dec 06, 2018 at 01:30:19PM +0100, Florian Weimer wrote: >> * Christian Brauner: >> >> > /* zombies */ >> > Zombies can be signaled just as any other process. No special error will be >> > reported since a zombie state is an unreliable state (cf. [3]). >> >> I still

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Florian Weimer
* Jürg Billeter: > On Thu, 2018-12-06 at 13:30 +0100, Florian Weimer wrote: >> * Christian Brauner: >> >> > /* zombies */ >> > Zombies can be signaled just as any other process. No special error will be >> > reported since a zombie state is an unreliable state (cf. [3]). >> >> I still disagree w

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Christian Brauner
On Thu, Dec 06, 2018 at 01:30:19PM +0100, Florian Weimer wrote: > * Christian Brauner: > > > /* zombies */ > > Zombies can be signaled just as any other process. No special error will be > > reported since a zombie state is an unreliable state (cf. [3]). > > I still disagree with this analysis.

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Jürg Billeter
On Thu, 2018-12-06 at 13:30 +0100, Florian Weimer wrote: > * Christian Brauner: > > > /* zombies */ > > Zombies can be signaled just as any other process. No special error will be > > reported since a zombie state is an unreliable state (cf. [3]). > > I still disagree with this analysis. If I kn

Re: [PATCH v4] signal: add taskfd_send_signal() syscall

2018-12-06 Thread Florian Weimer
* Christian Brauner: > /* zombies */ > Zombies can be signaled just as any other process. No special error will be > reported since a zombie state is an unreliable state (cf. [3]). I still disagree with this analysis. If I know that the target process is still alive, and it is not, this is a per