RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Hayes Wang
Mario Limonciello [mailto:mario_limoncie...@dell.com] [...] > + ret = hex2bin(buf, obj->string.pointer + 9, 6); > + if (ret < 0 || !is_valid_ether_addr(buf)) { > + netif_warn(tp, probe, tp->netdev, "Invalid MAC\n"); > + goto amacout; >

Re: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Pali Rohár
Hi! Below are my comments, all about coding style. On Monday 06 June 2016 12:19:29 Mario Limonciello wrote: > The RTL8153-AD supports a persistent system specific MAC address. > This means a device plugged into two different systems with host side > support will show different (but persistent) MAC