Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-19 Thread Chris Wilson
Quoting Chris Wilson (2019-06-12 08:42:05) > Quoting Kirill A. Shutemov (2019-06-12 02:46:34) > > On Sun, Jun 02, 2019 at 10:47:35PM +0100, Chris Wilson wrote: > > > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > > > index 404acdcd0455..aaf

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-12 Thread Chris Wilson
Quoting Kirill A. Shutemov (2019-06-12 02:46:34) > On Sun, Jun 02, 2019 at 10:47:35PM +0100, Chris Wilson wrote: > > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > > index 404acdcd0455..aaf88f85d492 100644 > > > --- a/mm/huge_memory.c > > > +

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-11 Thread Kirill A. Shutemov
On Sun, Jun 02, 2019 at 10:47:35PM +0100, Chris Wilson wrote: > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 404acdcd0455..aaf88f85d492 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2456,6 +2456,9 @@ static void _

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-02 Thread Chris Wilson
Quoting Matthew Wilcox (2019-03-07 15:30:51) > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 404acdcd0455..aaf88f85d492 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2456,6 +2456,9 @@ static void __split_huge_page(struct page *page, struct > list_head *list, >

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-02 Thread Chris Wilson
Quoting Matthew Wilcox (2019-06-02 11:51:50) > On Sat, Jun 01, 2019 at 12:44:28PM +0100, Chris Wilson wrote: > > Quoting Chris Wilson (2019-06-01 10:26:21) > > > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > > > Transparent Huge Pages are currently stored in i_pages as pointers to > > > > consec

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-02 Thread Chris Wilson
Quoting Matthew Wilcox (2019-06-02 11:51:50) > Thanks for the reports, Chris. > > I think they're both canaries; somehow the page cache / swap cache has > got corrupted and contains entries that it shouldn't. > > This second one (with the VM_BUG_ON_PAGE in __delete_from_swap_cache) > shows a regu

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-02 Thread Matthew Wilcox
On Sat, Jun 01, 2019 at 12:44:28PM +0100, Chris Wilson wrote: > Quoting Chris Wilson (2019-06-01 10:26:21) > > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > > Transparent Huge Pages are currently stored in i_pages as pointers to > > > consecutive subpages. This patch changes that to storing con

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-01 Thread Chris Wilson
Quoting Chris Wilson (2019-06-01 10:26:21) > Quoting Matthew Wilcox (2019-03-07 15:30:51) > > Transparent Huge Pages are currently stored in i_pages as pointers to > > consecutive subpages. This patch changes that to storing consecutive > > pointers to the head page in preparation for storing huge

Re: [PATCH v4] page cache: Store only head pages in i_pages

2019-06-01 Thread Chris Wilson
Quoting Matthew Wilcox (2019-03-07 15:30:51) > Transparent Huge Pages are currently stored in i_pages as pointers to > consecutive subpages. This patch changes that to storing consecutive > pointers to the head page in preparation for storing huge pages more > efficiently in i_pages. > > Large pa