Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Denis Efremov
On 01.08.2019 05:20, Masahiro Yamada wrote: The build time impact is very limited. I guess this measurement is unnecessary in the commit log. Thank you for your observations! It was not easy for me to guess to do it this way because of my limited knowledge about kbuild && modpost work. In v5

Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Masahiro Yamada
On Wed, Jul 31, 2019 at 5:54 PM Masahiro Yamada wrote: > > Hi. > > > > On Wed, Jul 31, 2019 at 3:12 AM Denis Efremov wrote: > > > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > > during the modpost. In most of the cases, a static symbol marked for > > exporting is an od

Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Masahiro Yamada
Hi. On Wed, Jul 31, 2019 at 3:12 AM Denis Efremov wrote: > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > during the modpost. In most of the cases, a static symbol marked for > exporting is an odd combination that should be fixed either by deleting > the exporting mar

Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-30 Thread Denis Efremov
Changes in v1: 1. Fixed indentations. 2. Removed lkml links from the description of the commit. Changes in v2: 1. Changed the 'n' variable type in the main function from size_t to int. Changes in v3: 1. Changed warning message from "%s is the static EXPORT_*" to "%s a static ..." 2. Improved