Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-10 Thread Steven Rostedt
On Mon, 9 Feb 2015 21:47:42 -0800 Alexei Starovoitov wrote: > On Mon, Feb 9, 2015 at 9:45 PM, Alexei Starovoitov wrote: > > I thought we already stated that. > > Here is the quote from perf_event.h: > > * # The RAW record below is opaque data wrt the ABI > > * # > >

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-10 Thread Steven Rostedt
Added Linus because he's the one that would revert changes on breakage. On Mon, 9 Feb 2015 21:45:21 -0800 Alexei Starovoitov wrote: > On Mon, Feb 9, 2015 at 9:16 PM, Steven Rostedt wrote: > > On Mon, 9 Feb 2015 23:08:36 -0500 > > Steven Rostedt wrote: > > > >> I don't want to get stuck with pi

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-09 Thread Alexei Starovoitov
On Mon, Feb 9, 2015 at 9:45 PM, Alexei Starovoitov wrote: > I thought we already stated that. > Here is the quote from perf_event.h: > * # The RAW record below is opaque data wrt the ABI > * # > * # That is, the ABI doesn't make any promises wrt to >

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-09 Thread Alexei Starovoitov
On Mon, Feb 9, 2015 at 9:16 PM, Steven Rostedt wrote: > On Mon, 9 Feb 2015 23:08:36 -0500 > Steven Rostedt wrote: > >> I don't want to get stuck with pinned kernel data structures again. We >> had 4 blank bytes of data for every event, because latency top hard >> coded the field. Luckily, the 64

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-09 Thread Steven Rostedt
On Mon, 9 Feb 2015 23:08:36 -0500 Steven Rostedt wrote: > I don't want to get stuck with pinned kernel data structures again. We > had 4 blank bytes of data for every event, because latency top hard > coded the field. Luckily, the 64 bit / 32 bit interface caused latency > top to have to use the

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-09 Thread Steven Rostedt
On Mon, 9 Feb 2015 19:45:57 -0800 Alexei Starovoitov wrote: > +static void print_netif_receive_skb(void *data, int size) > +{ > + struct ftrace_raw_netif_receive_skb { > + struct trace_entry t; > + void *skb; > + __u32 len; > + __u32 name; > +

Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C

2015-02-09 Thread Steven Rostedt
On Mon, 9 Feb 2015 19:45:57 -0800 Alexei Starovoitov wrote: > +int perf_event_mmap(int fd); > +int perf_event_poll(int fd); > +typedef void (*print_fn)(void *data, int size); > +void perf_event_read(print_fn fn); > +struct trace_entry { > + unsigned short type; > + unsigned cha