Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-06 Thread Mark Brown
On Wed, May 06, 2015 at 01:21:53PM +0100, Richard Fitzgerald wrote: > On Wed, May 06, 2015 at 12:48:49PM +0100, Mark Brown wrote: > > > 'IN1L Mux' = 'B' > > > 'IN1R Mux' = 'B' > > > It's much more readably obvious that both channels are set the same > > > rather than > > Right, but as I

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-06 Thread Richard Fitzgerald
On Wed, May 06, 2015 at 12:48:49PM +0100, Mark Brown wrote: > On Wed, May 06, 2015 at 10:24:05AM +0100, Richard Fitzgerald wrote: > > > No, I'm just saying I don't see how calling the mux positions "IN1AL" > > is any clearer than calling them "A" and "B". The "IN1AL" names of the > > DAPM widgets

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-06 Thread Mark Brown
On Wed, May 06, 2015 at 10:24:05AM +0100, Richard Fitzgerald wrote: > No, I'm just saying I don't see how calling the mux positions "IN1AL" > is any clearer than calling them "A" and "B". The "IN1AL" names of the > DAPM widgets is purely an internal detail that you wouldn't see through > the ALSA

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-06 Thread Richard Fitzgerald
On Tue, May 05, 2015 at 10:59:34PM +0100, Mark Brown wrote: > On Tue, May 05, 2015 at 02:31:29PM +0100, Richard Fitzgerald wrote: > > > We can't really tell people what the selection does because that depends on > > the external hardware. The A setting might be a headset mic, or a line in, > > or

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-05 Thread Mark Brown
On Tue, May 05, 2015 at 02:31:29PM +0100, Richard Fitzgerald wrote: > We can't really tell people what the selection does because that depends on > the external hardware. The A setting might be a headset mic, or a line in, > or a builtin mic... > All we can do is say what the selection is called

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-05 Thread Richard Fitzgerald
> > > > > +static const char * const wm8998_inmux_texts[] = { > > > > + "A", > > > > + "B", > > > > Those are some fun input names... > > > ... that's what the mux positions are called and it seems nice to have > > consistent > > naming for all similar muxes across channels and acro

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-05 Thread Mark Brown
On Tue, May 05, 2015 at 10:24:12AM +0100, Richard Fitzgerald wrote: > On Mon, May 04, 2015 at 12:39:43PM +0100, Mark Brown wrote: > > On Fri, May 01, 2015 at 04:15:18PM +0100, Richard Fitzgerald wrote: > > > + val = snd_soc_read(codec, ARIZONA_ASYNC_SAMPLE_RATE_1 + val); > > > + if

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-05 Thread Richard Fitzgerald
On Mon, May 04, 2015 at 12:39:43PM +0100, Mark Brown wrote: > On Fri, May 01, 2015 at 04:15:18PM +0100, Richard Fitzgerald wrote: > > > + switch (event) { > > + case SND_SOC_DAPM_PRE_PMU: > > + val = snd_soc_read(codec, ARIZONA_ASRC_RATE1); > > + val &= ARIZONA_ASRC_RATE1_M

Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

2015-05-04 Thread Mark Brown
On Fri, May 01, 2015 at 04:15:18PM +0100, Richard Fitzgerald wrote: > + switch (event) { > + case SND_SOC_DAPM_PRE_PMU: > + val = snd_soc_read(codec, ARIZONA_ASRC_RATE1); > + val &= ARIZONA_ASRC_RATE1_MASK; > + val >>= ARIZONA_ASRC_RATE1_SHIFT; > + > +