Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask

2019-01-09 Thread Mark Brown
On Sat, Dec 22, 2018 at 12:54:48AM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 21, 2018 at 11:21 PM wrote: > > Also add offset to RX channel select > Commit log seems a bit lacking. You could probably explain how you > found this, either when comparing datasheet macros, or some actual > error manif

Re: [PATCH v3 4/9] ASoC: sun4i-i2s: Fix offset mask

2018-12-21 Thread Chen-Yu Tsai
On Fri, Dec 21, 2018 at 11:21 PM wrote: > > From: Marcus Cooper > > Also add offset to RX channel select > > Signed-off-by: Marcus Cooper Commit log seems a bit lacking. You could probably explain how you found this, either when comparing datasheet macros, or some actual error manifested and yo