Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-10-03 Thread Andy Shevchenko
On Sat, Oct 3, 2020 at 2:36 AM Jonathan Neuschäfer wrote: > On Mon, Sep 28, 2020 at 10:35:46AM +0200, Uwe Kleine-König wrote: > > On Sun, Sep 27, 2020 at 11:10:44PM +0200, Jonathan Neuschäfer wrote: ... > > You can even check this with an LED using something like: > > > > pwm_apply(mypwm,

Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-10-02 Thread Jonathan Neuschäfer
On Mon, Sep 28, 2020 at 10:35:46AM +0200, Uwe Kleine-König wrote: > Hello Jonathan, > > On Sun, Sep 27, 2020 at 11:10:44PM +0200, Jonathan Neuschäfer wrote: [...] > > > > + if (state->enabled && duty != 0) { > > > > + res = regmap_write(pwm->ec->regmap, NTXEC_REG_ENABLE, > > >

Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-09-28 Thread Uwe Kleine-König
Hello Jonathan, On Sun, Sep 27, 2020 at 11:10:44PM +0200, Jonathan Neuschäfer wrote: > On Fri, Sep 25, 2020 at 08:30:37AM +0200, Uwe Kleine-König wrote: > > > + if (period > MAX_PERIOD_NS) { > > > + dev_warn(pwm->dev, > > > + "Period is not representable in 16 bits after d

Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-09-27 Thread Jonathan Neuschäfer
On Fri, Sep 25, 2020 at 08:30:37AM +0200, Uwe Kleine-König wrote: > Hello Jonathan, [...] > > +config PWM_NTXEC > > + tristate "Netronix embedded controller PWM support" > > + depends on MFD_NTXEC > > + help > > + Say yes here if you want to support the PWM output of the embedded > > +

Re: [PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-09-24 Thread Uwe Kleine-König
Hello Jonathan, On Thu, Sep 24, 2020 at 09:24:52PM +0200, Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM stat