subject:"Re\: \[PATCH v3 4\/6\] mm\/thp\: add THP allocation helper"

Re: [PATCH v3 4/6] mm/thp: add THP allocation helper

2020-11-06 Thread Ralph Campbell

On 11/6/20 12:01 AM, Christoph Hellwig wrote: +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern struct page *alloc_transhugepage(struct vm_area_struct *vma, + unsigned long addr); No need for the extern. And also here: do we actually need the stub, or can the

Re: [PATCH v3 4/6] mm/thp: add THP allocation helper

2020-11-06 Thread Christoph Hellwig

> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +extern struct page *alloc_transhugepage(struct vm_area_struct *vma, > + unsigned long addr); No need for the extern. And also here: do we actually need the stub, or can the caller make sure (using IS_ENABLED and similar)