Re: [PATCH v3 4/5] ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM

2018-05-21 Thread Marc Zyngier
On 21/05/18 10:34, Vladimir Murzin wrote: > On 18/05/18 15:39, Marc Zyngier wrote: >> +static inline int read_pmuver(void) >> +{ >> +/* PMUVers is not a signed field */ >> +u32 dfr0 = read_cpuid_ext(CPUID_EXT_DFR0); >> +return (dfr0 >> 24) & 0xf; >> +} > > Should we rule out versions p

Re: [PATCH v3 4/5] ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM

2018-05-21 Thread Vladimir Murzin
On 18/05/18 15:39, Marc Zyngier wrote: > +static inline int read_pmuver(void) > +{ > + /* PMUVers is not a signed field */ > + u32 dfr0 = read_cpuid_ext(CPUID_EXT_DFR0); > + return (dfr0 >> 24) & 0xf; > +} Should we rule out versions prior v3 here or in __armv8pmu_probe_pmu()? Thanks