Re: [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-12 Thread Peter Ujfalusi
On 12/11/2012 08:25 AM, Thierry Reding wrote: >> +static const struct of_device_id of_pwm_leds_match[] = { >> +{ .compatible = "pwm-leds", }, >> +{}, >> +}; > > Doesn't this cause a compiler warning for !OF builds? This is not causing any compiler warnings. -- Péter -- To unsubscribe fr

Re: [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:37AM +0100, Peter Ujfalusi wrote: [...] > +LED sub-node properties: > +- pwms : PWM property, please refer to: > + Documentation/devicetree/bindings/pwm/pwm.txt Instead of only referring to the generic PWM binding document, this should probably explain what the PWM

Re: [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 11:00:37 +0100, Peter Ujfalusi wrote: > Support for device tree booted kernel. > > For usage see: > Documentation/devicetree/bindings/leds/leds-pwm.txt > > Signed-off-by: Peter Ujfalusi Acked-by: Grant Likely The other patches in this series look good to. g. -- To unsu