RE: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-05 Thread Wu, Hao
> Subject: Re: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private > feature > > Thanks for your quick response, I'm OK with most changes. Some comments > inline. > > On Tue, Aug 04, 2020 at 08:56:12PM +0800, Wu, Hao wrote: > > > Subject: [PATCH v3 4/

Re: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-05 Thread Xu Yilun
Thanks for the word smith. I'll add these changes. Thanks, Yilun On Tue, Aug 04, 2020 at 11:45:33AM -0700, Tom Rix wrote: > Some minor edits. > > I have added definitions for fec, kr, and rs. > > Reviewed-by: Tom Rix > > Tom > > > --- /dev/null > > +++ b/Documentation/fpga/dfl-n3000-nios.rst

Re: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-05 Thread Xu Yilun
Thanks for your quick response, I'm OK with most changes. Some comments inline. On Tue, Aug 04, 2020 at 08:56:12PM +0800, Wu, Hao wrote: > > Subject: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private > > feature > > > +#define NIOS_INIT0x1000 > > +#define NIOS_INIT_DONEBIT(0) > > +#de

RE: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-04 Thread Wu, Hao
> Subject: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature > > This patch adds support for the nios handshake private feature on Intel > N3000 FPGA Card. This private feature provides a handshake interface to > FPGA NIOS firmware, which receives retimer configuration command f