Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-05-05 Thread Pavel Machek
On Thu 2015-04-30 18:47:17, Pavel Machek wrote: > Hi! > > > >From af56dde07c34b203f5c40c8864bfd55697b0aad0 Mon Sep 17 00:00:00 2001 > > From: Christoph Hellwig > > Date: Fri, 24 Apr 2015 11:26:00 +0200 > > Subject: suspend: sane block I/O handling > > > > stop abusing struct page functionality a

Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-05-04 Thread Rafael J. Wysocki
On Friday, May 01, 2015 10:21:56 AM Christoph Hellwig wrote: > On Thu, Apr 30, 2015 at 07:34:41PM +0200, Pavel Machek wrote: > > > Signed-off-by: Christoph Hellwig > > > > Tested-by: Pavel Machek > > Acked-by: Pavel Machek > > > > (thinkpad x60 in shutdown mode, platform mode has some problems

Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-05-01 Thread Christoph Hellwig
On Thu, Apr 30, 2015 at 07:34:41PM +0200, Pavel Machek wrote: > > Signed-off-by: Christoph Hellwig > > Tested-by: Pavel Machek > Acked-by: Pavel Machek > > (thinkpad x60 in shutdown mode, platform mode has some problems, but > they are probably not related). Thanks! Rafeal, do you want to ta

Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-04-30 Thread Pavel Machek
Hi! > >From af56dde07c34b203f5c40c8864bfd55697b0aad0 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Fri, 24 Apr 2015 11:26:00 +0200 > Subject: suspend: sane block I/O handling > > stop abusing struct page functionality and the swap end_io handler, and > instead add a modified version

Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-04-24 Thread Ming Lin
On Fri, Apr 24, 2015 at 9:17 AM, Christoph Hellwig wrote: > On Thu, Apr 23, 2015 at 04:04:35PM -0700, Ming Lin wrote: >> From: Kent Overstreet >> >> Make bio submission in kernel/power/block_io.c to properly submit >> bios also when bio_chain is not available. In that case, it's not >> necessary

Re: [PATCH v3 4/4] PM: submit bio in a sane way in cases without bio_chain

2015-04-24 Thread Christoph Hellwig
On Thu, Apr 23, 2015 at 04:04:35PM -0700, Ming Lin wrote: > From: Kent Overstreet > > Make bio submission in kernel/power/block_io.c to properly submit > bios also when bio_chain is not available. In that case, it's not > necessary to handle refcount with bio_get(), but it's saner to simply > cal