Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-06 Thread Johannes Thumshirn
On 06/06/2017 09:19 AM, Christoph Hellwig wrote: > Can you rebase on top of the new uuid_t type and the plain uuid_* > prefixed helpers here: > > http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next > > I'll declare that branch stable soon and don't want to introduce > more us

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-06 Thread Christoph Hellwig
Can you rebase on top of the new uuid_t type and the plain uuid_* prefixed helpers here: http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next I'll declare that branch stable soon and don't want to introduce more users of the old types. Thanks!

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-06 Thread Johannes Thumshirn
On 06/05/2017 07:31 AM, Christoph Hellwig wrote: > What about a little helper like this: ? > > static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len, > void *id, off_t *off) > { > struct nvme_ns_identifier_hdr hdr = { > .nidt = type, >

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-04 Thread Christoph Hellwig
What about a little helper like this: ? static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len, void *id, off_t *off) { struct nvme_ns_identifier_hdr hdr = { .nidt = type, .nidl = len, }; u16 status;

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-03 Thread Sagi Grimberg
switch (type) { case NVME_NQN_NVME: diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index cfc5c7fb0ab7..4c6cb5ea1186 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -46,6 +46,7 @@ struct nvmet_ns { u32

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-02 Thread Christoph Hellwig
On Fri, Jun 02, 2017 at 04:46:40PM +0300, Sagi Grimberg wrote: > >> switch (type) { >> case NVME_NQN_NVME: >> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h >> index cfc5c7fb0ab7..4c6cb5ea1186 100644 >> --- a/drivers/nvme/target/nvmet.h >> +++ b/drivers/nvme/target

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-02 Thread Johannes Thumshirn
On 06/02/2017 03:46 PM, Sagi Grimberg wrote: >> +uuid_beuuid; > > This should be uuid_le to match the rest of NVMe. Ahm, are you sure? $ PAGER= git grep -E uuid_\(l\|b\)e drivers/nvme drivers/nvme/host/fabrics.c:61: uuid_be_gen(&host->id); drivers/nvme/host/fabrics.c:78: uuid_be_g

Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list

2017-06-02 Thread Sagi Grimberg
switch (type) { case NVME_NQN_NVME: diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h index cfc5c7fb0ab7..4c6cb5ea1186 100644 --- a/drivers/nvme/target/nvmet.h +++ b/drivers/nvme/target/nvmet.h @@ -46,6 +46,7 @@ struct nvmet_ns { u32