Hi,
On Tue, Aug 04, 2015 at 08:21:36AM +, Opensource [Adam Thomson] wrote:
> > The header states GPL v2+.
>
> Yes, and this matches the "GPL" string as I understand it. The following is
> taken from "include/linux/module.h":
>
> ---
> /*
> * The following license idents are currently accept
On August 03, 2015 18:26, Sebastian Reichel wrote:
> > > > +MODULE_LICENSE("GPL");
> > >
> > > MODULE_LICENSE("GPL v2");
> >
> > If I do this then I need to update the file license disclaimer at the top,
> > as
> > right now they match and are correct as far as I can tell. Is this change
> > nee
Hi,
On Mon, Aug 03, 2015 at 03:23:11PM +, Opensource [Adam Thomson] wrote:
> > > +MODULE_LICENSE("GPL");
> >
> > MODULE_LICENSE("GPL v2");
>
> If I do this then I need to update the file license disclaimer at the top, as
> right now they match and are correct as far as I can tell. Is this ch
On July 25, 2015 18:27, Sebastian Reichel wrote:
> Hi Adam,
>
> The driver looks mostly fine. I have a few comments, though:
>
> On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote:
> > Signed-off-by: Adam Thomson
>
> Please add a short description to the commit message.
>
Ok, I can
Hi Adam,
The driver looks mostly fine. I have a few comments, though:
On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote:
> Signed-off-by: Adam Thomson
Please add a short description to the commit message.
> [...]
>
> +config FG_DA9150
Please name the config entry BATTERY_DA9150 to
5 matches
Mail list logo
