Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-02-14 Thread Jaroslav Kysela
Dne 14. 02. 21 v 7:43 Perry Yuan napsal(a): >>> @@ -287,6 +291,18 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol >>> *kcontrol, >>> return err; >>> } >>> >>> +#if IS_ENABLED(CONFIG_DELL_PRIVACY) >>> + /* dell privacy LED trigger state changed by muted/unmute s

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-02-13 Thread Perry Yuan
Hi Mark: Thanks for your review. On 2021/1/13 1:54, Mark Brown wrote: On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote: Some new Dell system is going to support audio internal micphone privacy setting from hardware level with micmute led state changing When micmute hotkey pressed by

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-02-13 Thread Perry Yuan
Hi Mark: Thanks for your review. On 2021/1/13 1:54, Mark Brown wrote: On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote: Some new Dell system is going to support audio internal micphone privacy setting from hardware level with micmute led state changing When micmute hotkey pressed by

RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Yuan, Perry
g; alsa-de...@alsa-project.org; > linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org > Subject: RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control > supports > > > >> -Original Message- > > >> From: Yuan, Perry > >

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Takashi Iwai
On Tue, 19 Jan 2021 21:33:04 +0100, Hans de Goede wrote: > > Hi, > > On 1/19/21 5:33 PM, Limonciello, Mario wrote: > -Original Message- > From: Yuan, Perry > Sent: Tuesday, January 12, 2021 11:18 > To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > hde

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Hans de Goede
Hi, On 1/19/21 5:33 PM, Limonciello, Mario wrote: -Original Message- From: Yuan, Perry Sent: Tuesday, January 12, 2021 11:18 To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com Cc: lgirdw...@gmail.com; broo.

RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-19 Thread Limonciello, Mario
> >> -Original Message- > >> From: Yuan, Perry > >> Sent: Tuesday, January 12, 2021 11:18 > >> To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > >> hdego...@redhat.com; mgr...@linux.intel.com > >> Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; > >> li

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-18 Thread Mark Brown
On Sat, Jan 16, 2021 at 11:50:31PM +0800, Perry Yuan wrote: > On 2021/1/13 1:54, Mark Brown wrote: > > > + bool micmute_led; > > What is this for, it never seems to be read except for in the function > > where it's set? > Do you mean i can use a local micmute_led var in the function? Yes. sig

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-16 Thread Perry Yuan
On 2021/1/13 1:50, Limonciello, Mario wrote: -Original Message- From: Yuan, Perry Sent: Tuesday, January 12, 2021 11:18 To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-pr

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-16 Thread Perry Yuan
Hi Mark, Thanks for your review feedback. On 2021/1/13 1:54, Mark Brown wrote: On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote: Some new Dell system is going to support audio internal micphone privacy setting from hardware level with micmute led state changing When micmute hotkey p

Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-12 Thread Mark Brown
On Wed, Jan 13, 2021 at 01:18:14AM +0800, Perry Yuan wrote: > Some new Dell system is going to support audio internal micphone > privacy setting from hardware level with micmute led state changing > When micmute hotkey pressed by user, soft mute will need to be enabled > firstly in case of pop noi

RE: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports

2021-01-12 Thread Limonciello, Mario
> -Original Message- > From: Yuan, Perry > Sent: Tuesday, January 12, 2021 11:18 > To: oder_ch...@realtek.com; pe...@perex.cz; ti...@suse.com; > hdego...@redhat.com; mgr...@linux.intel.com > Cc: lgirdw...@gmail.com; broo...@kernel.org; alsa-de...@alsa-project.org; > linux-kernel@vger.kerne