On Wed, Jan 28, 2015 at 3:31 PM, Paolo Bonzini wrote:
>>> >
>>> > No need for this function and nested_cpu_has_virt_x2apic_mode. Just
>>> > inline them in their caller(s). Same for other cases throughout the
>>> > series.
>>> >
>> Do you mean that we should also inline the same functions in the
On 28/01/2015 07:19, Wincy Van wrote:
>> >
>> > No need for this function and nested_cpu_has_virt_x2apic_mode. Just
>> > inline them in their caller(s). Same for other cases throughout the
>> > series.
>> >
> Do you mean that we should also inline the same functions in the other
> patches of t
On 28/01/2015 11:19, Wincy Van wrote:
> > Most of the functions are just used once. If you want to keep them,
> > please place them all close to the existing ones.
>
> Yep, I will inline the functions like nested_vmx_check_virt_x2apic and keep
> the nested_cpu_has series.
Okay, thanks!
Paolo
-
On Wed, Jan 28, 2015 at 5:39 AM, Paolo Bonzini wrote:
>
>
> On 24/01/2015 11:21, Wincy Van wrote:
>> +static void nested_vmx_disable_intercept_for_msr(unsigned long
>> *msr_bitmap_l1,
>> + unsigned long
>> *msr_bitmap_nested,
>> +
On Wed, Jan 28, 2015 at 5:37 AM, Paolo Bonzini wrote:
>
>
> On 24/01/2015 11:21, Wincy Van wrote:
>> + memset(vmx_msr_bitmap_nested, 0xff, PAGE_SIZE);
>
> Most bytes are always 0xff. It's better to initialize it to 0xff once,
> and set the bit here if !nested_cpu_has_virt_x2apic_mode(vmcs12
On 24/01/2015 11:21, Wincy Van wrote:
> +static void nested_vmx_disable_intercept_for_msr(unsigned long
> *msr_bitmap_l1,
> + unsigned long
> *msr_bitmap_nested,
> + u32 msr, int type)
> +{
> + int f
On 24/01/2015 11:21, Wincy Van wrote:
> + memset(vmx_msr_bitmap_nested, 0xff, PAGE_SIZE);
Most bytes are always 0xff. It's better to initialize it to 0xff once,
and set the bit here if !nested_cpu_has_virt_x2apic_mode(vmcs12).
> + if (nested_cpu_has_virt_x2apic_mode(vmcs12))
Pleas
7 matches
Mail list logo
