Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

2015-10-02 Thread Jassi Brar
On 2 October 2015 at 15:02, Lee Jones wrote: > On Fri, 02 Oct 2015, Jassi Brar wrote: > >> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: >> >> >> >> > + >> > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) >> > >> It should be(inst) * 4 > > I'm guessing you mean: > > (

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

2015-10-02 Thread Lee Jones
On Fri, 02 Oct 2015, Jassi Brar wrote: > On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: > > > > > + > > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) > > > It should be(inst) * 4 I'm guessing you mean: ((mdev)->base + ((inst) * 4)) ? > > +/** > > + * STi Mailbox

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

2015-10-01 Thread Jassi Brar
On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: > + > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) > It should be(inst) * 4 > +/** > + * STi Mailbox device data > + * > + * An IP Mailbox is currently composed of 4 instances > + * Each instance is currently composed of